Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webhooks #13

Closed
nilsenpaul opened this issue Feb 26, 2019 · 10 comments
Closed

Add support for webhooks #13

nilsenpaul opened this issue Feb 26, 2019 · 10 comments

Comments

@nilsenpaul
Copy link

Somehow, in a newer install of this plugin, the webhook url doesn't get sent to Mollie, as it did previously. I think you only need to add the supportsWebhooks method to the gateway, returning true. Please do this for the feature/issuers version to, as that's the one we always use (when will this be merged into master?).

@andris-sevcenko andris-sevcenko changed the title Webhook doesn't get sent to Mollie Add support for webhooks Feb 26, 2019
@andris-sevcenko
Copy link
Contributor

andris-sevcenko commented Feb 26, 2019

This is probably due to the bug where the notification link was being sent out when it shouldn't have been (craftcms/commerce-omnipay@44ec14e).

I'll enable webhooks for Mollie and I plan to get a release for all Omnipay gateways this week.

@nilsenpaul
Copy link
Author

@andris-sevcenko you're my hero.

andris-sevcenko added a commit that referenced this issue Feb 28, 2019
@andris-sevcenko
Copy link
Contributor

Closed via a32ba5b

@nilsenpaul
Copy link
Author

@andris-sevcenko When I use the v2.x-dev versions for both commerce-mollie and commerce-ominpay, I get the following webhook error:

Exception while processing webhook: Return value of craft\commerce\omnipay\base\Gateway::processWebHook() must be an instance of craft\web\Response, null returned

Exception thrown in /var/www/.../vendor/craftcms/commerce-omnipay/src/base/Gateway.php:349

@nilsenpaul
Copy link
Author

@andris-sevcenko Sorry, I almost forgot that it's World Compliment Day. You're doing a great job, keep up the good work!

@andris-sevcenko
Copy link
Contributor

@nilsenpaul load up Discord, let's chat!

@nilsenpaul
Copy link
Author

@andris-sevcenko Can we do that later today? Starting lunch in a minute :)

@andris-sevcenko
Copy link
Contributor

@nilsenpaul just don't forget :)

andris-sevcenko added a commit that referenced this issue Mar 1, 2019
@lenvanessen
Copy link

@andris-sevcenko this doesn't work. For some reason mollie webhooks don't work with the redirect that the endpoint gives.

The url for customer returns should be different from the url for the webhook. The customer return url should have the redirect to the order page, but the webhook should simply look-up the payment and process is, if mollie encounters a redirect they simply abort the call it seems

@andris-sevcenko
Copy link
Contributor

@lenvanessen that sounds like a different issue. Can you open a new issue with detailed steps on how to reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants