Skip to content

Commit

Permalink
Tidy PR
Browse files Browse the repository at this point in the history
  • Loading branch information
nfourtythree committed Apr 30, 2021
1 parent 5db0d21 commit 18bec2c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## Unreleased

- Added string error message when an error occurs after the submitting payment information to PayPal Checkout.
### Added
- Added the `locale` parameter for when customizing the PayPal SDK script. ([#123](https://github.com/craftcms/commerce-paypal-checkout/pull/35))

### Fixed
- Fixed a bug where Commerce payment errors weren’t being returned

### Fixed
- Fixed a bug where the PayPal Checkout gateway was incorrectly showing in the available gateways list for CP payments. ([#30](https://github.com/craftcms/commerce-paypal-checkout/issues/30))
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ This is required when paying with an alternative payment currency due to the int

This gateway allows the passing of certain query string parameters, at runtime, as specified in the [PayPal documentation](https://developer.paypal.com/docs/checkout/reference/customize-sdk/#query-parameters).

THe allowed parameters are `currency` (as detailed above), `locale`, `disable-card` and `disable-funding`.
The allowed parameters are `currency` (as detailed above), `disable-card`, `disable-funding` and `locale`.

As an example to disable PayPal credit funding you could output the payment form as follows:

Expand Down
2 changes: 1 addition & 1 deletion src/gateways/Gateway.php
Original file line number Diff line number Diff line change
Expand Up @@ -737,10 +737,10 @@ private function _isPaymentInBaseCurrency(Order $order, Transaction $transaction
private function _sdkQueryParameters(Array $passedParams): string
{
$passedParamsMergeKeys = [
'locale',
'currency',
'disable-card',
'disable-funding',
'locale',
];
$intent = strtolower(self::PAYMENT_TYPES[$this->paymentType]);
$params = [
Expand Down

0 comments on commit 18bec2c

Please sign in to comment.