Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow “locale” parameter #35

Merged
merged 2 commits into from May 4, 2021

Conversation

billmn
Copy link
Contributor

@billmn billmn commented Apr 30, 2021

PayPal is currently using the wrong language using Safari if the user is not logged in with their PayPal account.

In my case, using Chrome, the PayPal popup shows the Italian language (correct).

Using Safari, the PayPal popup shows the English language (wrong). I have already verified that the language setting on Safari was "Italian".

Using the PayPal "locale" parameter it is at least possible to force the language to be used in the popup.

PayPal is currently using the wrong language using Safari if the user is not logged in with their PayPal account.

In my case, using Chrome, the PayPal popup shows the Italian language (correct).

Using Safari, the PayPal popup shows the English language (wrong). I have already verified that the language setting on Safari was "Italian".

Using the PayPal "locale" parameter it is at least possible to force the language to be used in the popup.
@nfourtythree nfourtythree self-requested a review April 30, 2021 11:57
Copy link
Collaborator

@nfourtythree nfourtythree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @billmn

Thank you for the PR, will get this merged in!

Thanks.

@nfourtythree nfourtythree merged commit 9af6fec into craftcms:develop May 4, 2021
@billmn billmn deleted the allow-locale-parameter branch May 5, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants