Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perItemDiscount is different depending on user language setting #1174

Closed
stevenvandemoortele opened this issue Dec 12, 2019 · 1 comment
Closed

Comments

@stevenvandemoortele
Copy link

Description

Decimal numbers in Per Item Discount are rendered differently in commerce depending on the logged in users language settings.
A discount set to for example 0.75 will render as 0 in dutch

Steps to reproduce

  1. Create a discount with the Per Item Discount set to a decimal number, for example 0.75
  2. Switch user language to "nederlands"
  3. Go back to the discount, Per Item Discount will be shown as 0 instead of 0.75

Additional info

  • Craft version: 3.3.16.3
  • PHP version: 7.2.25
  • Database driver & version: MySQL 5.7.27
  • Plugins & versions: Commerce 2.2.8

Discount with user language set to English (United Kingdom)
per-item-discount-EN

Discount with user language set to Nederlands
per-item-discount-NL

@nfourtythree
Copy link
Contributor

Hi @stevenvandemoortele

Thank you for bringing this to our attention.

This has been fixed and will be included in the upcoming 3.1 update.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants