Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save as a new product button doesn't save value from custom field #1393

Closed
xhuang9 opened this issue Mar 12, 2020 · 2 comments · Fixed by #1394
Closed

Save as a new product button doesn't save value from custom field #1393

xhuang9 opened this issue Mar 12, 2020 · 2 comments · Fixed by #1394

Comments

@xhuang9
Copy link

xhuang9 commented Mar 12, 2020

Description

When "save as a new product" of an existing product, custom fields like "Plain Text", "Assets", "Categories", "Redactor" doesn't get popped over. It will be set to empty value or field default value.
But variant value set correctly. I checked "Craft::$app->getRequest();" from action "commerce/products/save-product". Seems "_ bodyParams" missing the custom field value from product.

Steps to reproduce

  1. create a product, add field plain text, assets, categories, redactor in it
  2. put some value in those fields and save it
  3. reopen the previous product just saved
  4. change the SKU to a unique value, and click "save as a new product" on top right

Additional info

  • Craft version: 3.4.9
  • PHP version: 7.3.1
  • Database driver & version:
  • Plugins & versions: 3.0.11
@lukeholder
Copy link
Member

Looks like a bug with the new delta update feature implemented in Craft CMS 3.4 - Will look into a fix.

@billythekid
Copy link
Contributor

I've noticed this doesn't happen on other Elements, such as entries. Save as new on those and they retain their values fine. Any word on progress on this @lukeholder? Cheers.

@lukeholder lukeholder self-assigned this Apr 9, 2020
@brandonkelly brandonkelly transferred this issue from craftcms/commerce Apr 15, 2020
@brandonkelly brandonkelly transferred this issue from craftcms/cms Apr 18, 2020
@lukeholder lukeholder self-assigned this Apr 24, 2020
brandonkelly added a commit that referenced this issue Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants