Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decimal in Flat Amount offer #1400

Closed
RichardJong opened this issue Apr 21, 2020 · 1 comment
Closed

Allow decimal in Flat Amount offer #1400

RichardJong opened this issue Apr 21, 2020 · 1 comment
Assignees
@nfourtythree
Labels
bug 📣 promotions

Comments

@RichardJong
Copy link

Description

Allow decimals in Flat amount offer (baseDiscount)

Steps to reproduce

  1. Add new discount
  2. Go to tab 'Actions'
  3. Enter 3,5 (or 3.5) in baseDiscount field
  4. View your newly added discount
  5. Discount is 35 instead of 3,5

Fix

Make baseDiscount field type "text" instead of "number"
@nfourtythree
Copy link
Contributor

Hi @nfourtythree

Thank you for pointing this out.

We have pushed a fix for this that will be included in the next release.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfourtythree nfourtythree

Labels
bug 📣 promotions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukeholder @nfourtythree @RichardJong