Purge incomplete carts not respecting timezone

[engram-design]

Looking at the purge incomplete carts code:

commerce/src/services/Carts.php

Line 289 in 0500fe0

->andWhere('[[orders.dateUpdated]] <= :edge', ['edge' => $edge->format('Y-m-d H:i:s')])

This will not always be in UTC, which the timestamp for dateUpdated is recorded in. Instead it'll be in the configured time (sometimes local time, sometimes UTC). It's be a good idea to use the Db::prepareDateForDb() function:

Changing

$edge->format('Y-m-d H:i:s')

to

Db::prepareDateForDb($edge)

should ensure we're comparing dates in UTC properly.

[lukeholder]

Thanks for reporting, fixed for the next release.