Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Removing existing variant title and resaving re populates the title with previously saved rather than failing validation as required. #3384

Closed
samhibberd opened this issue Feb 13, 2024 · 3 comments
Labels
bug commerce4 Issues related to Commerce v4

Comments

@samhibberd
Copy link

What happened?

I'm not sure if this is by design, but it's caught us out a few time as we would expect it to throw an error as required?

I have testing in a fresh install of the latest commerce:

San.Quentin.24.-.Spoke.Chain.mp4

Craft CMS version

4.7.2

Craft Commerce version

4.4.1.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@samhibberd samhibberd added commerce4 Issues related to Commerce v4 bug labels Feb 13, 2024
nfourtythree added a commit that referenced this issue Feb 28, 2024
…-submission

Fixed #3384 variant title form submission
@nfourtythree
Copy link
Contributor

Hi @samhibberd

Thank you for raising this, it appears you have spotted something that has been in existence since 2.0.

We have pushed a fix for this which will be included in the next release of Commerce.

To get this early, change your craftcms/commerce requirement in your project's composer.json to:

"require": {
  "craftcms/commerce": "dev-develop#6a4669901e7bdd151fe77a196f7d1652aeb5333c as 4.5.0",
  "...": "..."
}

Then run composer update.

Thanks!

@samhibberd
Copy link
Author

Awesome thanks!

@lukeholder
Copy link
Member

4.5.1 is now out with this fix. Happy leap day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug commerce4 Issues related to Commerce v4
Projects
None yet
Development

No branches or pull requests

3 participants