Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount percentages and comma's #592

Closed
nilsenpaul opened this issue Nov 28, 2018 · 0 comments
Closed

Discount percentages and comma's #592

nilsenpaul opened this issue Nov 28, 2018 · 0 comments
Labels

Comments

@nilsenpaul
Copy link
Contributor

Description

Our editors use comma's as a decimal separator. That works fine, except when they try to add a discount with decimals. Then 7,5% becomes 7% after saving. If you use a dot as the decimal separator, the correct discount percentage gets saved. However, if you re-open that discount, the field says 7,50%. Saving that sets the percentage back to 7%.

Steps to reproduce

  1. Use a language with commas as decimal separator (Dutch, in our case)
  2. Whilst using Dutch, try to navigate to discounts and create a new one
  3. Use 7,5% as the discount percentage and save
  4. Reopen that discount. Percentage is now 7%.
@lukeholder lukeholder added the bug label Nov 29, 2018
lukeholder added a commit that referenced this issue Aug 22, 2019
Fixed #592 saving discount percentage with comma decimal separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants