Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Product editor unknown error #1291

Merged
merged 1 commit into from Feb 21, 2020
Merged

Fixed Product editor unknown error #1291

merged 1 commit into from Feb 21, 2020

Conversation

jmauzyk
Copy link

@jmauzyk jmauzyk commented Feb 20, 2020

Was getting an unknown error when trying to access the Product editor by double clicking a product in a relational field. Looks like the generalVariantFields macro was getting passed a variant but not a product as well.

@nfourtythree nfourtythree merged commit 896caa7 into craftcms:develop-v2 Feb 21, 2020
@nfourtythree
Copy link
Contributor

Hey @jmauzyk

Thank you for this, I have merged it in and it will be included in the next release.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants