Check if coupon availaible with discount condition formula #1705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Craft's commerce does not return an error when a user wants to add an existing coupon code to the cart via the action
commerce/cart/update-cart
and the order condition formula did not pass.The solution
I added this simple check based on your code style and existing code to validate and send an error when the coupon is not valid because of the condition formula.
Please let me know if this PR is problematic, I am ready to change the code or adapt to your guidelines.
Thanks for Craft and thanks for the commerce plugin. Much love from Montreal ❤