Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show fail flash message when trying to delete a user with an existing… #3071

Merged
merged 1 commit into from May 30, 2023

Conversation

Romanavr
Copy link
Contributor

… order/subscription

Description

Shows a fail flash message that we can't delete such user because it have an existing order or subscription.

Related issues

#3070

@lukeholder
Copy link
Member

lukeholder commented May 30, 2023

Thanks for this PR.

We have added this stop-gap measure in Commerce to show an exception on the first undeletable user through the flash error. This will be in the next release.

Although not ideal, we expect Craft 5 will introduce a better way for Commerce to hook into user deletions.

The fix will be included in the next Commerce release.

To get the fix early, change your craftcms/commerce requirement in composer.json to:

"require": {
  "craftcms/commerce": "dev-develop#151d0b250e16459a875df1654dabf73bd41cabf3 as 4.2.10",
  "...": "..."
}

Then run composer update.

@nfourtythree
Copy link
Contributor

Version 4.2.10 of Commerce is now out with this fix.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants