Update variant SKU and title before save instead of before validation

[johnnynotsolucky]

Description

A variants title and SKU are generated automatically based on their respective templates. For this to work correctly when writing code against Commerce APIs and not using validation, we need to ensure that those two side-effects are moved out of validation otherwise they will never be updated correctly without a CLI or CP invoked resave of a product.

This PR removes the updateTitleand updateSku functions to the beforeSave function so that validation of a variant isn't required to generate those two fields data.

Related issues

[lukeholder]

Thanks for reporting this.

Instead of doing this only before saving, we have decided to do it in addition to before validation. See 75f4a0a.

This means we ensure that it is generated in both cases.

This doesn't break anything since the SKU will not be generated again if it already exists.

This will be in the next release and I will comment here once released. Thanks.

[nfourtythree]

Commerce 4.3.1 has now been released with these changes.