[4.x] Add warning alert if upgrade command is not completed #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeholder
changed the title
lukeholder
changed the title
gcamacho079
reviewed
Jun 25, 2024
| if ($columnsExist) { | ||
| Event::on(Cp::class, Cp::EVENT_REGISTER_ALERTS, static function($event) { | ||
| $event->alerts[] = [ | ||
| 'content' => Craft::t('commerce', '<strong>Commerce 4 upgrade incomplete.</strong> Please ensure the <a href="https://craftcms.com/docs/commerce/4.x/upgrading.html#performing-the-upgrade" target="_blank" rel="noopener noreferrer">Commerce 4 upgrade command</a> has finished running.'), |
There was a problem hiding this comment.
@lukeholder just popping in because I recently started updating some translations that include brand names and saw that this was relevant. Because the brand names aren’t translated, I’ve started wrapping them with <span lang="en"></span> so that screen readers switch their pronunciation to English when encountering them in the context of another language.
You can see an example of this in this recent commit, and Brandon also provided some guidance here about ensuring they're not being escaped.
There was a problem hiding this comment.
thanks @gcamacho079 ! will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need to get a better warning message before merging this: