Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some feed options are always ignored #1356

Closed
i-just opened this issue Jul 24, 2023 · 1 comment
Closed

some feed options are always ignored #1356

i-just opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels

Comments

@i-just
Copy link
Contributor

i-just commented Jul 24, 2023

Description

While reviewing PR 1353, I noticed that some feed options were always being ignored: queueTtr, queueMaxRetry and assetDownloadCurl, no matter what value was set in the feed-me.php config file.

Steps to reproduce

  1. create feed-me.php config, with the following config (for either all feeds or a specific one)
  'queueTtr' => 150,
  'queueMaxRetry' => 2,
  'assetDownloadCurl' => true,
  1. create a feed that is supposed to grab an image from provided url; make sure that asset doesn’t exist in the CMS;
  2. set a breakpoint here https://github.com/craftcms/feed-me/blob/develop/src/helpers/AssetHelper.php#L39 and notice that the $assetDownloadCurl is always false
  3. run the feed and notice that the job is added to the queue with the default ttr of 300

Additional info

  • Craft version: 3.8.16 and 4.4.16.1
  • PHP version: 7.2 and 8.1
  • Database driver & version: n/a
  • Plugins & versions: Feed Me 4.7.0 and 5.2.0
@i-just i-just added the bug label Jul 24, 2023
@i-just i-just self-assigned this Jul 24, 2023
@angrybrad
Copy link
Member

Resolved in #1357 and will be included in the next v4 and v5 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants