Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/797 empty string values and defaults #1271

Merged
merged 6 commits into from Apr 5, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 4, 2023

Description

Adjustments for empty value vs no value and setEmptyValues and using defaults.

  • If mapped values are defined in the feed and are empty and setEmptyValues is on - clear the existing values.
  • If mapped values are not defined in the feed, ignore them (don’t update existing values).
  • If mapped values are defined in the feed and are empty, setEmptyValues is on, and defaults are mapped - use the defaults.

@angrybrad - if you could please let me know once this is merged into develop, I would like to test it again, primarily because of the difference in handling matrix blocks.

Related issues

#797 (comment)

@i-just i-just marked this pull request as ready for review April 4, 2023 15:26
@i-just i-just requested a review from angrybrad as a code owner April 4, 2023 15:26
@angrybrad angrybrad merged commit 68720c7 into v4 Apr 5, 2023
7 checks passed
angrybrad added a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants