Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Commit

Permalink
xdebug and 7.0 don't play nice
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonmccallister committed Feb 4, 2021
1 parent d8d67b7 commit b3a9c57
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-V2.md
Expand Up @@ -4,6 +4,7 @@

### Changed
- The `share` command returns a helpful message when ngrok is not found.
- The `xon` command will now return an error when trying to enable xdebug for sites with PHP version 7.0

### Fixed
- Fixed and error where custom ports were not being used for the proxy container.
Expand Down
6 changes: 6 additions & 0 deletions command/xon/xon.go
@@ -1,6 +1,7 @@
package xon

import (
"fmt"
"os"

"github.com/docker/docker/client"
Expand Down Expand Up @@ -86,6 +87,11 @@ func NewCommand(home string, docker client.CommonAPIClient, output terminal.Outp
site = sites[selected]
}

// php 7.0 does not support xdebug
if site.Version == "7.0" {
return fmt.Errorf("Xdebug with PHP 7.0 is not supported")
}

// enable xdebug for the sites hostname
if err := cfg.EnableXdebug(site.Hostname); err != nil {
return err
Expand Down

0 comments on commit b3a9c57

Please sign in to comment.