Added the ability to sync variant meta fields #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onisation' into feature/variant-metafield-synchronisation
|
Made a couple of tweaks that collects all the Settings into a dedicated section! Otherwise, looks great! 💞 |
AugustMiller
reviewed
Apr 2, 2024
|
|
||
| > [!NOTE] | ||
| > Setting `apiKey`, `apiSecretKey`, `accessToken`, and `hostName` via `shopify.php` will override Project Config values set via the control panel during [app setup](#create-a-shopify-app). You can still reference environment values from the config file with `craft\helpers\App::env()`. | ||
|
|
There was a problem hiding this comment.
Collected syncProductMetafields and syncVariantMetafields into this section, and added keys for the other settings.
| @@ -117,16 +117,16 @@ Products from your Shopify store are represented in Craft as product [elements]( | |||
|
|
|||
| ### Synchronization | |||
|
|
|||
| Once the plugin has been configured, you can perform an initial synchronization of all products via the **Shopify Sync** utility. | |||
| Once the plugin has been configured, you can perform an initial synchronization of all products via the command line. | |||
There was a problem hiding this comment.
Smart inversion here. CLI is going to be more reliable for 99% of users!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the ability to sync variant meta fields as well as settings around controlling what meta fields are sync'd into Craft.
The two new settings are:
syncProductMetafieldsthis istrueby defaultsyncVariantMetafields, this isfalseby default as it adds an extra API call for each variant in a product.You can override these config settings in your project's
shopify.phpconfig file.Related issues
#99