New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio-ui] Do not allow user Author and Reviewer to "Edit" static-assets, templates and scripts from the "Dependencies" dialog #1661

Closed
alhambrav opened this Issue Dec 1, 2017 · 2 comments

Comments

@alhambrav
Member

alhambrav commented Dec 1, 2017

Expected behavior

User Author and Reviewer should not be given a link to "Edit" static-assets, templates and scripts from the "Dependencies" dialog. They should just be given a View link instead in the "Dependencies" dialog.

(It would be nice for user Reviewer and user Author to get a View link for previewable static-assets, scripts and templates in the Dependencies dialog)

screen shot 2017-12-01 at 9 10 10 am

Actual behavior

The user Author and Reviewer gets the Edit link from the dependencies link for templates, scripts

Steps to reproduce the problem

  • Create a site using website_editorial
  • Create a user Author and user Reviewer
  • Login as user Author
  • Open the Sidebar and navigate to the articles
  • Right click on an article and click on Dependencies, notice that for scripts and templates, the user Author is given an Edit link and no link at all for static-assets. (It would be nice to give the author a View link from the Dependencies dialog for previewable static-assets, scripts and templates)
  • Logout and login as user Reviewer.
  • Open the Sidebar and navigate to the articles
  • Right click on an article and click on Dependencies, notice that for scripts, templates and static-assets, no link is given to the user in the Dependencies dialog. (It would be nice for user Reviewer to get a View link for previewable static-assets, scripts and templates)

Log/stack trace (use https://gist.github.com)

Specs: version, OS, browser, etc.

OS X, Chrome browser
Studio Version Number: 3.0.2-SNAPSHOT-cb71a7
Build Number: cb71a720818783bbf5adb9ec9211ae238780f037
Build Date/Time: 11-30-2017 10:56:38 -0500

@sumerjabri sumerjabri added this to Backlog in Crafter CMS v3.0.x via automation Dec 1, 2017

@sumerjabri sumerjabri added this to the Crafter CMS v3.0.3 milestone Dec 1, 2017

@sumerjabri sumerjabri assigned jvega190 and unassigned jvega190 Dec 1, 2017

@vestrada vestrada assigned vestrada and unassigned jvega190 Dec 7, 2017

@vestrada vestrada moved this from Backlog to In Progress in Crafter CMS v3.0.x Dec 8, 2017

vestrada added a commit to vestrada/studio-ui that referenced this issue Dec 11, 2017

craftercms/craftercms#1661 - [studio-ui] Do not allow user Author and…
… Reviewer to "Edit" static-assets, templates and scripts from the "Dependencies" dialog #1661

@vestrada vestrada referenced this issue Dec 11, 2017

Merged

#1661 #716

@vestrada

This comment has been minimized.

Show comment
Hide comment
@vestrada
Member

vestrada commented Dec 11, 2017

@vestrada vestrada moved this from In Progress to Test & Validate in Crafter CMS v3.0.x Dec 11, 2017

@vestrada vestrada assigned alhambrav and unassigned vestrada Dec 11, 2017

@alhambrav

This comment has been minimized.

Show comment
Hide comment
@alhambrav

alhambrav Dec 11, 2017

Member

Verified fixed.

Member

alhambrav commented Dec 11, 2017

Verified fixed.

@alhambrav alhambrav closed this Dec 11, 2017

Crafter CMS v3.0.x automation moved this from Test & Validate to Completed Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment