Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[craftercms] Add new gradle task to run the scripts on src/test-suite for pretest check out #1770

Closed
luishernandezmonge opened this issue Jan 15, 2018 · 9 comments

Comments

@luishernandezmonge
Copy link
Member

luishernandezmonge commented Jan 15, 2018

Request

The new task should execute the next scripts on src/test-suite (according to with the platform where it will be executed):
-initialSetupCheckForTestScript.sh
-initialSetupCheckForTestScript.bat

How it would work

@sumerjabri sumerjabri added this to Backlog in Crafter CMS v3.0 via automation Jan 15, 2018
@sumerjabri sumerjabri added this to the Crafter CMS v3.0.5 milestone Jan 15, 2018
@russdanner russdanner changed the title [craftercms] Add new grade task to run the scripts on src/test-suite for pretest check out [craftercms] Add new gradle task to run the scripts on src/test-suite for pretest check out Jan 22, 2018
@cortiz
Copy link
Member

cortiz commented Feb 5, 2018

@sumerjabri / @luishernandezmonge there is a small problem with these:
I can make the run but since it's already running in a Gradle task I need to discard any output since I'll have issues with the redirection of outputs that already are redirect (mostly because its a gradle task running gradle tasks from CLI)

There are 2 options:

  1. discard any output
  2. Make the scripts redirect it's outputs to File.

@sumerjabri
Copy link
Member

@cortiz have it redirect to a logs folder with a test-suite subfolder
Make sure logs is in .gitignore of craftercms
Make sure logs and logs/test-suite are auto-created.
Make sure to overwrite the logs every run (so the logs can't grow) since these logs are transient in nature.

cortiz pushed a commit to cortiz/craftercms that referenced this issue Feb 7, 2018
@cortiz cortiz mentioned this issue Feb 7, 2018
@cortiz cortiz assigned luishernandezmonge and unassigned cortiz Feb 7, 2018
@cortiz
Copy link
Member

cortiz commented Feb 7, 2018

Added the new task as selftest

@cortiz cortiz moved this from Backlog to Test & Validate in Crafter CMS v3.0 Feb 7, 2018
sumerjabri added a commit that referenced this issue Feb 7, 2018
@luishernandezmonge
Copy link
Member Author

Checked on my side.
However, I will assign this to vita to double check and get feedback on this.
@alhambrav Please, can you check this ticket?

@alhambrav
Copy link
Member

@luishernandezmonge checked on my side too, OS X is okay, in Windows, the command line window used to launch the gradlew selftest is closed at the end of the test (as I mentioned in our conversation)

@luishernandezmonge
Copy link
Member Author

I'm working on this now

@luishernandezmonge
Copy link
Member Author

Added the fix on the next PR: https://github.com/craftercms/test-suite/pull/291 @alhambrav Please, can you test this again?

@alhambrav
Copy link
Member

@luishernandezmonge Verified okay on Windows and OS X.

@luishernandezmonge
Copy link
Member Author

Verified as fixes and implemented, according with comment of above

Crafter CMS v3.0 automation moved this from Test & Validate to Completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Crafter CMS v3.0
  
Completed
Development

No branches or pull requests

4 participants