Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployer] Add support for a git push processor #2017

Closed
sumerjabri opened this issue Apr 5, 2018 · 5 comments
Closed

[deployer] Add support for a git push processor #2017

sumerjabri opened this issue Apr 5, 2018 · 5 comments

Comments

@sumerjabri
Copy link
Member

Please add a new processor that can push to a remote git repo. The idea is that the deployer can then propagate the deployed content to remote repos.

@marosivanco
Copy link

Implemented the GitPushProcessor, but i am unable to push. Do I need any rights to push a feature branch?

@sumerjabri
Copy link
Member Author

@marosivanco send us a pull-request with the code and we'll review/merge. Please review these docs before you send the PR:
https://github.com/craftercms/craftercms/blob/master/CODE_OF_CONDUCT.md
https://github.com/craftercms/craftercms/blob/master/CONTRIBUTING.md
https://github.com/craftercms/craftercms/blob/master/GIT_WORKFLOW.md

You'll need to fork the repository:
https://github.com/craftercms/deployer

The code should live along with the other processors:
https://github.com/craftercms/deployer/tree/master/src/main/java/org/craftercms/deployer/impl/processors

Thank you for contributing!

@marosivanco
Copy link

Permission denied. Any idea?:

> git push --set-upstream origin feature/2017
ERROR: Permission to craftercms/deployer.git denied to marosivanco.
fatal: Could not read from remote repository.

> git remote -v
origin  ssh://git@github.com/craftercms/deployer.git (fetch)
origin  ssh://git@github.com/craftercms/deployer.git (push)

@cortiz
Copy link
Member

cortiz commented Apr 18, 2018

Yes, you don’t have permissions to write into craftercms/deployer , you need to fork it, then push your branch and the do the pull request as explain by Sumer

@sumerjabri sumerjabri added this to Completed in Crafter CMS v3.1 via automation Aug 15, 2018
@sumerjabri sumerjabri added this to Backlog in Crafter CMS v3.0 via automation Aug 21, 2018
@sumerjabri sumerjabri removed this from Completed in Crafter CMS v3.1 Aug 21, 2018
@sumerjabri sumerjabri moved this from Backlog to Completed in Crafter CMS v3.0 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Crafter CMS v3.0
  
Completed
Development

No branches or pull requests

3 participants