Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio-ui] Copy paste is not copying more than one level #602

Closed
russdanner opened this issue Mar 15, 2017 · 7 comments
Closed

[studio-ui] Copy paste is not copying more than one level #602

russdanner opened this issue Mar 15, 2017 · 7 comments

Comments

@russdanner
Copy link
Member

Using the copy feature in the Site Content menu for pages with multiple sub-sections, only the first sub-set is copied. For example if I were copying all of #1, only levels 1 & 2 would be pasted to the new location. Levels 3 & 4 wouldn't be copied.

@russdanner russdanner self-assigned this Mar 15, 2017
@russdanner
Copy link
Member Author

I did a test where I tried this and confirmed it's an issue. To me looks like a UI issue.
screen shot 2017-03-16 at 1 07 44 pm

It looks like the Dialog request the child pages but then only displays 2 levels.
http://localhost:8080/studio/api/1/services/api/1/clipboard/get-items.json?site=globalintegrity&user=admin&nocache=Thu%20Mar%2016%202017%2013:03:59%20GMT-0400%20(EDT)

Response

{"item":{"name":"index.xml","internalName":"Contact us","contentType":"/page/contact-us","uri":"/site/website/contact-us/index.xml","path":"/site/website/contact-us","browserUri":"/contact-us","navigation":false,"floating":true,"hideInAuthoring":false,"previewable":true,"lockOwner":"","user":"admin","userFirstName":"admin","userLastName":"","nodeRef":null,"metaDescription":null,"site":"globalintegrity","page":true,"component":false,"document":false,"asset":false,"isContainer":true,"container":true,"disabled":false,"savedAsDraft":false,"submitted":false,"submittedForDeletion":false,"scheduled":false,"deleted":false,"inProgress":true,"live":false,"inFlight":false,"isDisabled":false,"isSavedAsDraft":false,"isInProgress":true,"isLive":false,"isSubmittedForDeletion":false,"isScheduled":false,"isNavigation":false,"isDeleted":false,"isNew":true,"isSubmitted":false,"isFloating":false,"isPage":true,"isPreviewable":true,"isComponent":false,"isDocument":false,"isAsset":false,"isInFlight":false,"eventDate":"2017-03-15T11:37:30-04:00","endpoint":null,"timezone":null,"numOfChildren":1,"scheduledDate":null,"mandatoryParent":null,"isLevelDescriptor":false,"categoryRoot":null,"lastEditDate":"2017-03-15T11:37:30-04:00","form":"/page/contact-us","formPagePath":"simple","renderingTemplates":[{"uri":"/templates/web/page-contact.ftl","name":"DEFAULT"}],"folder":false,"submissionComment":null,"components":null,"documents":null,"levelDescriptors":null,"pages":null,"parentPath":null,"orders":[{"name":null,"id":"default","order":-1.0,"disabled":null,"placeInNav":null}],"children":[{"name":"index.xml","internalName":"About ","contentType":"/page/article","uri":"/site/website/contact-us/about/index.xml","path":"/site/website/contact-us/about","browserUri":"/contact-us/about","navigation":true,"floating":false,"hideInAuthoring":false,"previewable":true,"lockOwner":"","user":"admin","userFirstName":"admin","userLastName":"","nodeRef":null,"metaDescription":null,"site":"globalintegrity","page":true,"component":false,"document":false,"asset":false,"isContainer":true,"container":true,"disabled":false,"savedAsDraft":false,"submitted":false,"submittedForDeletion":false,"scheduled":false,"deleted":false,"inProgress":true,"live":false,"inFlight":false,"isDisabled":false,"isSavedAsDraft":false,"isInProgress":true,"isLive":false,"isSubmittedForDeletion":false,"isScheduled":false,"isNavigation":false,"isDeleted":false,"isNew":true,"isSubmitted":false,"isFloating":false,"isPage":true,"isPreviewable":true,"isComponent":false,"isDocument":false,"isAsset":false,"isInFlight":false,"eventDate":"2017-03-16T13:02:20-04:00","endpoint":null,"timezone":null,"numOfChildren":1,"scheduledDate":null,"mandatoryParent":null,"isLevelDescriptor":false,"categoryRoot":null,"lastEditDate":"2017-03-16T13:02:20-04:00","form":"/page/article","formPagePath":"simple","renderingTemplates":[{"uri":"/templates/web/page-article.ftl","name":"DEFAULT"}],"folder":false,"submissionComment":null,"components":null,"documents":null,"levelDescriptors":null,"pages":null,"parentPath":null,"orders":[{"name":null,"id":"default","order":0.0,"disabled":null,"placeInNav":null}],"children":[],"new":true,"reference":false,"newFile":false,"levelDescriptor":false}],"new":true,"reference":false,"newFile":false,"levelDescriptor":false}}

When it sends the copy command to the server, it's then only for 2 levels

@russdanner russdanner added the bug label Mar 16, 2017
@russdanner russdanner changed the title [studio] Copy paste is not copying more than one level [studio-ui] Copy paste is not copying more than one level Mar 16, 2017
@russdanner russdanner added this to the Crafter CMS v2.5.6 milestone Mar 16, 2017
@russdanner russdanner assigned vestrada and unassigned russdanner Mar 16, 2017
@vestrada vestrada added this to In Progress in Crafter CMS v2.5.x Mar 16, 2017
vestrada added a commit to vestrada/studio-ui that referenced this issue Mar 16, 2017
vestrada added a commit to vestrada/studio-ui that referenced this issue Mar 16, 2017
@vestrada
Copy link
Member

vestrada commented Mar 16, 2017

2.5.X PR: craftercms/studio-ui#294
Master PR: craftercms/studio-ui#295

@vestrada
Copy link
Member

Fixed, Copy is copying more than 1 level.
Paste is not pasting more than 1 level, the issue seems to be on back end. Please take a look.

@vestrada vestrada assigned russdanner and unassigned vestrada Mar 16, 2017
@vestrada vestrada moved this from In Progress to Backlog/Scheduled in Crafter CMS v2.5.x Mar 16, 2017
sumerjabri added a commit to craftercms/studio-ui that referenced this issue Mar 17, 2017
sumerjabri added a commit to craftercms/studio-ui that referenced this issue Mar 17, 2017
@vestrada
Copy link
Member

Styles:
2.5.X PR: craftercms/studio-ui#296
Master PR: craftercms/studio-ui#297

@russdanner
Copy link
Member Author

Copy UI now sends all copy values

{"item":[{"uri":"/site/website/contact-us/about/index.xml","children":[{"uri":"/site/website/contact-us/about/contact-us/index.xml","children":[{"uri":"/site/website/contact-us/about/contact-us/search/index.xml","children":[{"uri":"/site/website/contact-us/about/contact-us/search/contact-us/index.xml"}]}]}]}]}```

@russdanner
Copy link
Member Author

Client side sends paste command with proper parent
http://localhost:8080/studio/api/1/services/api/1/clipboard/paste-item.json?site=globalintegrity&parentPath=/site/website/about/contact-us/index.xml&nocache=Fri%20Mar%2017%202017%2013:47:29%20GMT-0400%20(EDT)

@russdanner
Copy link
Member Author

Closed this as it was merged and fixed some time ago

@russdanner russdanner moved this from Backlog/Scheduled to In Progress in Crafter CMS v2.5.x Sep 19, 2017
@russdanner russdanner moved this from In Progress to Completed in Crafter CMS v2.5.x Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Crafter CMS v2.5.x
  
Completed
Development

No branches or pull requests

2 participants