Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio] Add bucket to S3 upload API response #6467

Closed
3 of 5 tasks
russdanner opened this issue Jan 23, 2024 · 5 comments
Closed
3 of 5 tasks

[studio] Add bucket to S3 upload API response #6467

russdanner opened this issue Jan 23, 2024 · 5 comments

Comments

@russdanner
Copy link
Member

russdanner commented Jan 23, 2024

Latest version

  • The issue is in the develop branch
  • The issue is in the latest released 4.1.x
  • The issue is in the latest released 4.0.x
  • The issue is in the latest released 3.1.x

Duplicates

  • I have searched the existing issues

Is your enhancement request related to a problem? Please describe.

Update the following API response to include the bucket name for the given profile
/studio/api/2/aws/s3/upload.json

Describe the solution you'd like

Current Response:

{
    "response": { ... },
    "item": {
        "name": "005.jpeg",
        "url": "/remote-assets/s3/s3-image/005.jpeg",
        "folder": false
    }
}

Expected Response

 {
    "response": {  },
    "item": {
        "name": "my-image.jpeg",
        "url": "/remote-assets/s3/s3-image/my-image.jpeg",
        "folder": false,
        "bucketName": "my-bucket"
    }
}
@russdanner russdanner added this to the Next Release milestone Jan 23, 2024
@russdanner russdanner changed the title [studio-ui] Add bucket to S3 Upload API [studio] Add bucket to S3 Upload API Jan 23, 2024
@russdanner russdanner changed the title [studio] Add bucket to S3 Upload API [studio] Add bucket to S3 upload API Jan 23, 2024
@russdanner russdanner changed the title [studio] Add bucket to S3 upload API [studio] Add bucket to S3 upload API response Jan 23, 2024
@rart
Copy link
Member

rart commented Jan 23, 2024

Related to #6453

@sumerjabri
Copy link
Member

@rart please validate in 4.1 and develop

@sumerjabri
Copy link
Member

Related to #2508

@rart rart removed their assignment Jan 23, 2024
@rart
Copy link
Member

rart commented Jan 23, 2024

@rart
Copy link
Member

rart commented Jan 29, 2024

Updates verified: prefix is now included.

{
    "response": {
        "code": 0,
        "message": "OK",
        "remedialAction": "",
        "documentationUrl": ""
    },
    "item": {
        "name": "craftercms-0F172A.png",
        "url": "/remote-assets/s3/s3-image/craftercms-0F172A.png",
        "folder": false,
        "bucketName": "blob-store-test",
        "prefix": "preview"
    }
}

@rart rart closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants