Preview target rebuild in engine instead of http call #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumerjabri
requested changes
Sep 27, 2023
|
@sumerjabri I added the removal processor to UM. It will match for the same processor with the same properties for removal. |
jmendeza
suggested changes
Oct 3, 2023
| * @return true if all properties are the same, false otherwise | ||
| */ | ||
| protected boolean hasAllProperties(Map<String, Object> processorObj) { | ||
| if (processorObj.get(PROCESSOR_NAME_CONFIG_KEY).equals(processorName)) { |
There was a problem hiding this comment.
This condition can be inverted to reduce indentation
There was a problem hiding this comment.
I updated this. Thank you!
| import static org.craftercms.deployer.impl.DeploymentConstants.PROCESSOR_NAME_CONFIG_KEY; | ||
|
|
||
| /** | ||
| * Operation to remove a new processor to the pipeline of the target |
There was a problem hiding this comment.
"Operation to remove a processor from the pipeline of the target"
There was a problem hiding this comment.
I updated this. Thank you!
jmendeza
approved these changes
Oct 4, 2023
sumerjabri
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket reference or full description of what's in the PR
craftercms/craftercms#6223