Improve API response in not found response use case #344 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumerjabri
approved these changes
Aug 12, 2022
…ribute to support this controller running in studio
avasquez614
requested changes
Aug 22, 2022
| @@ -60,12 +66,15 @@ public class RestScriptsController extends AbstractController { | |||
|
|
|||
| private static final String SCRIPT_URL_FORMAT = "%s.%s.%s"; // {url}.{method}.{scriptExt} | |||
|
|
|||
| protected static final String REST_SERVICES_ROOT = "/api/1/services"; | |||
There was a problem hiding this comment.
It also needs to map to /api/*. That's the main root clients use now.
jmendeza
force-pushed
the
bugfix/344
branch
2 times, most recently
from
f9a5214
to
7486839
Compare
avasquez614
approved these changes
Aug 23, 2022
avasquez614
pushed a commit
that referenced
this pull request
Sep 1, 2022
sumerjabri
pushed a commit
that referenced
this pull request
Sep 6, 2022
sumerjabri
added a commit
that referenced
this pull request
Sep 6, 2022
sumerjabri
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/craftersoftware/craftercms/issues/344
Improve API response in not found response use case