[4.1.x][6518] Level Descriptor being counted as children, also ...X more items button not working when publishing #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating optionsByPath to fetch children #6518
jvega190
commented
Feb 8, 2024
| @@ -210,9 +210,9 @@ export default [ | |||
| optionsByPath = { | |||
| ...optionsByPath, | |||
| ...createPresenceTable(expanded, (value) => ({ | |||
| ...createGetChildrenOptions(chunk, pluckProps(payload, true, 'limit', 'excludes')), | |||
There was a problem hiding this comment.
Those are the global options for children, they need to go before the specific options per path
rart
requested changes
Feb 9, 2024
… rendered at the beginning of the view (on each page) #6491
jvega190
commented
Feb 12, 2024
| if (children.levelDescriptor) { | ||
| chunk.childrenByParentPath[parentPath].push(children.levelDescriptor.path); | ||
| chunk.totalByPath[children.levelDescriptor.path] = 0; | ||
| } | ||
| children.forEach((item) => { |
There was a problem hiding this comment.
This was causing the children to be rendered before the levelDescriptor in some scenarios.
rart
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
craftercms/craftercms#6518