[4.1.x][6533] Node selector control should only provide the user with an Edit option for content items that are editable by Studio #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they were being labeled as embedded #6533
rart
requested changes
Feb 19, 2024
static-assets/components/cstudio-forms/controls/node-selector.js
Outdated
Show resolved
Hide resolved
Comment on lines
-105
to
-115
| var me = this; | ||
|
|
||
| var site = CStudioAuthoringContext.site; | ||
| var path = this._self.repoPath; | ||
| var isUploadOverwrite = true; | ||
|
|
||
| for (var i = 0; i < this.properties.length; i++) { | ||
| if (this.properties[i].name === 'repoPath') { | ||
| path = this.properties[i].value; | ||
|
|
||
| path = this.processPathsForMacros(path); |
There was a problem hiding this comment.
What about all this removed code, including parsing the path macros, etc?
There was a problem hiding this comment.
The file upload behavior when editing was to upload/override the item (removed code). From the ticket, the behavior should be displaying the editor (if editable). That's what the browse-file datasource does.
jvega190
force-pushed
the
bugfix/4.1.x/6533
branch
from
8c1569b
to
b28d0a0
Compare
rart
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
craftercms/craftercms#6533