Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebox Tools: Domain Migration / Enforce HTTPS #48

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Codebox Tools: Domain Migration / Enforce HTTPS #48

merged 2 commits into from
Mar 2, 2017

Conversation

jonsharratt
Copy link
Member

@jonsharratt jonsharratt commented Mar 2, 2017 •
edited

What did you implement:

Helps with #30

Add codebox plugin to allow the start of adding in new tools.

How did you implement it:

  • Put together a tool to allow migration of domains for packages already published. It will also enforce that these urls are https.
  • Also means anyone who adds a custom domain to API gateway can then update previously published packages.

How can we verify it:

  • Deploy serverless with a stage e.g. --stage test
  • Publish a package
  • Run sls codebox domain --stage test --host custom.domain.com
  • All package.json tarball urls will be updated

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO

@jonsharratt jonsharratt added the wip label Mar 2, 2017
@jonsharratt jonsharratt mentioned this pull request Mar 2, 2017
Closed
@jonsharratt jonsharratt merged commit 09f252a into master Mar 2, 2017
@jonsharratt jonsharratt deleted the codebox-tools branch March 2, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonsharratt