Fix particles when viewport scaled #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current version particles do not consider the current viewport zoom when drawing themselve to the canvas. This PR fixes that and also adds an option to specify an offset from the base entity it is attached to. original contribution in pr craftyjs#743 by @johnHacksworth . additional documentation & misc added by me.
|
The issue can be seen in the requirebin demo here. Also uploaded to |
mucaho
pushed a commit
that referenced
this pull request
Mar 16, 2015
Fix particles when viewport scaled
|
minor fix, so going ahead and merging since no objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version particles do not consider the current viewport zoom when drawing themselve to the canvas. This PR fixes that and also adds an option to specify an offset from the base entity it is attached to.
original contribution in pr #743 by @johnHacksworth .
additional documentation & misc added by me.