Various improvements to Motion system #884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #876
Now when user sets
vx = 1
, the entity will move1px
each frame, depending on the current target fpsCrafty.timer.FPS()
. Note that this should also work in the cases when user selects differenttimer.stepMode
(e.g.variable
), as the calculation is still done usingdt
and adtFactor
derived from the desired target FPS.gravityConst
before activatinggravity()
leads to inconsistent stateSupportable
,Twoway
andMultiway
Future additions
this.y = hit._y - this._h; // snap entity to ground object
.As you can see, this won't snap correctly with the polygon hitbox being larger/smaller than the actual entity. Should the user be allowed to specify his own snap function?
terminal velocity
that defaults to the velocity caused by gravity after 12 frames) and document for user that he should make his platforms at leastterminal velocity + 1
high -max(entity._h, platform._h) > terminal velocity