Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: added a little bit about the error that some expo users will come across into the readme #8

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

michaelessiet
Copy link
Contributor

I wrote about the error some expo users will come across with package compatibility. The packages they will have version issues with are react-native-reanimated and react-native-svg.

@craftzdog
Copy link
Owner

craftzdog commented Sep 5, 2022

I guess it's enough to mention the reanimated documentation, no? It can be changed in the future.

@michaelessiet
Copy link
Contributor Author

Yes, we could do that, but I think it would be better to explain it here too since it's an integral part of the package. Since it's a package that will be used by both beginners to advanced developers having a detailed documentation of all the steps of installation and any issues they might run into would be good, especially for beginner developers who are just starting out with React native/Expo. And I noticed that the reanimated documentation doesn't cover the warning message that I wrote about.

@craftzdog
Copy link
Owner

Makes sense. Can you mention the reanimated documentation just in case?

@michaelessiet
Copy link
Contributor Author

Ok, I'll add it in

@michaelessiet
Copy link
Contributor Author

Makes sense. Can you mention the reanimated documentation just in case?

I just added a line that has a link to the documentation in it

README.md Outdated Show resolved Hide resolved
@craftzdog craftzdog merged commit 4fc448b into craftzdog:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants