Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send PRAGMA queries to SELECT handler (Android) #91

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Send PRAGMA queries to SELECT handler (Android) #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions android/src/main/java/dog/craftz/sqlite_2/RNSqlite2Module.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public void run() {
String sql = sqlQuery.getString(0);
ReadableArray queryArgs = sqlQuery.getArray(1);
try {
if (isSelect(sql)) {
if (isSelectOrPragmaQuery(sql)) {
results[i] = doSelectInBackgroundAndPossiblyThrow(sql, queryArgs, db);
} else { // update/insert/delete
if (readOnly) {
Expand Down Expand Up @@ -284,8 +284,10 @@ private static WritableNativeArray convertPluginResultToArray(SQLitePLuginResult
return data;
}

private static boolean isSelect(String str) {
return startsWithCaseInsensitive(str, "select");

private static boolean isSelectOrPragmaQuery(String str) {
return startsWithCaseInsensitive(str, "select") ||
(startsWithCaseInsensitive(str, "pragma") && !str.contains("="));
}
private static boolean isInsert(String str) {
return startsWithCaseInsensitive(str, "insert");
Expand Down