On Android, allow PRAGMA statements that assign when invoked via exec
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you add some tests to https://github.com/craftzdog/react-native-sqlite-2/blob/master/test/app.js? |
|
Ah, will add. |
|
Added some tests and also tested them on Android & iOS. |
craftzdog
requested changes
Jul 5, 2021
| new Promise((resolve) => { | ||
| let sql = "PRAGMA journal_mode" | ||
| db._db.exec([{sql: sql, args: []}], false, (_, result) => { | ||
| journal_mode = result[0].rows[0].journal_mode |
There was a problem hiding this comment.
Add const or it causes ReferenceError
| new Promise((resolve) => { | ||
| let sql = "PRAGMA main.wal_checkpoint(FULL)" | ||
| db._db.exec([{sql: sql, args: []}], false, (_, result) => { | ||
| row = result[0].rows[0] |
There was a problem hiding this comment.
Add const or it causes ReferenceError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error on Android
when accessing
execdirectly to try to run assigning PRAGMA statements, such asPRAGMA journal_mode = WAL.