Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies should not result in an exception #51

Closed
dtanzer opened this issue Jul 12, 2016 · 0 comments
Closed

Circular dependencies should not result in an exception #51

dtanzer opened this issue Jul 12, 2016 · 0 comments
Assignees
Milestone

Comments

@dtanzer
Copy link

dtanzer commented Jul 12, 2016

This build script

plugins {
    id "com.craigburke.client-dependencies" version "1.1.4"
}

clientDependencies {
    installDir = 'src/main/resources/static/vendor'

    npm {
        'react' ('15.x.x')
        'react-dom' ('15.x.x')
        'babelify' ('7.3.0')
        'babel-preset-react' ('6.x.x')
    }
}

throws the following exception:

* What went wrong:
Execution failed for task ':web-frontend:clientReport'.
> com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: Circular dependency created by dependency babel-types@^6.9.0

It seems like circular dependencies are supported by npm, so they should also be supported by the client dependencies plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants