Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Django 4.2 #71

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Test on Django 4.2 #71

merged 1 commit into from
Oct 16, 2023

Conversation

adamchainz
Copy link
Contributor

Add tests with the new Django LTS release, and tidy up test configuration.

@@ -3,14 +3,13 @@
envlist = {py36,py39}-{dj32}
{py38,py310}-{dj40}
{py38,py310}-{dj41}

toxworkdir = {homedir}/.tox-django-typed-models
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The {homedir} substitution was removed in tox 4: https://tox.wiki/en/latest/upgrading.html#substitutions-removed

I think we should stick with the default .tox directory, I don't see why it was changed. I also added the .gitignore rule for .tox.

Comment on lines -13 to +12
coverage run {envbindir}/py.test --ds=test_settings typedmodels/tests.py {posargs}
coverage run {envbindir}/pytest --ds=test_settings typedmodels/tests.py {posargs}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pytest command changed to pytest in 3.0.0 (2016): https://docs.pytest.org/en/7.1.x/changelog.html#release-3-0-0

(py.test still works but best to use the new one)

@adamchainz adamchainz force-pushed the django_4.2 branch 2 times, most recently from c21252a to 3798206 Compare October 13, 2023 20:52
@adamchainz
Copy link
Contributor Author

I’d like to make a PR for Django 5.0, but I’ll wait for this one to be merged before I put the effort in.

There’s at least one breakage on Django 5.0: TypedModelMetaclass._patch_fields_cache needs to update to use the new get_fields() signature per django/django@1754c2c.

Copy link
Owner

@craigds craigds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks. sorry I ignored this since april

@craigds craigds merged commit 5cb7ebd into craigds:master Oct 16, 2023
0 of 16 checks passed
@adamchainz adamchainz deleted the django_4.2 branch October 16, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants