-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Django 4.2 #71
Conversation
@@ -3,14 +3,13 @@ | |||
envlist = {py36,py39}-{dj32} | |||
{py38,py310}-{dj40} | |||
{py38,py310}-{dj41} | |||
|
|||
toxworkdir = {homedir}/.tox-django-typed-models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The {homedir}
substitution was removed in tox 4: https://tox.wiki/en/latest/upgrading.html#substitutions-removed
I think we should stick with the default .tox
directory, I don't see why it was changed. I also added the .gitignore
rule for .tox
.
coverage run {envbindir}/py.test --ds=test_settings typedmodels/tests.py {posargs} | ||
coverage run {envbindir}/pytest --ds=test_settings typedmodels/tests.py {posargs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pytest command changed to pytest
in 3.0.0 (2016): https://docs.pytest.org/en/7.1.x/changelog.html#release-3-0-0
(py.test
still works but best to use the new one)
c21252a
to
3798206
Compare
I’d like to make a PR for Django 5.0, but I’ll wait for this one to be merged before I put the effort in. There’s at least one breakage on Django 5.0: |
3798206
to
df16b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks. sorry I ignored this since april
Add tests with the new Django LTS release, and tidy up test configuration.