throwing not supported exceptions rather than not implemented.

craiggwilson · Sep 20, 2012 · 0a32bef · 0a32bef
1 parent 2097869
commit 0a32bef
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/src/MongoDB.OData/Typed/TypedMetadata.cs b/src/MongoDB.OData/Typed/TypedMetadata.cs
@@ -75,7 +75,7 @@ public IEnumerable<ResourceType> GetDerivedTypes(ResourceType resourceType)
 
         public ResourceAssociationSet GetResourceAssociationSet(ResourceSet resourceSet, ResourceType resourceType, ResourceProperty resourceProperty)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public bool HasDerivedTypes(ResourceType resourceType)

diff --git a/src/MongoDB.OData/Typed/TypedQueryProvider.cs b/src/MongoDB.OData/Typed/TypedQueryProvider.cs
@@ -24,17 +24,17 @@ public bool IsNullPropagationRequired
 
         public object GetOpenPropertyValue(object target, string propertyName)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public IEnumerable<KeyValuePair<string, object>> GetOpenPropertyValues(object target)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public object GetPropertyValue(object target, ResourceProperty resourceProperty)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public IQueryable GetQueryRootForResourceSet(ResourceSet resourceSet)

diff --git a/src/MongoDB.OData/Typed/TypedResourceTypeAnnotation.cs b/src/MongoDB.OData/Typed/TypedResourceTypeAnnotation.cs
@@ -6,7 +6,7 @@
 
 namespace MongoDB.OData.Typed
 {
-    public class TypedResourceTypeAnnotation
+    internal class TypedResourceTypeAnnotation
     {
         private readonly BsonClassMap _classMap;
 

diff --git a/src/MongoDB.OData/Typed/TypedUpdateProvider.cs b/src/MongoDB.OData/Typed/TypedUpdateProvider.cs
@@ -29,7 +29,7 @@ public TypedUpdateProvider(TypedDataSource currentDataSource, TypedMetadata meta
 
         public void AddReferenceToCollection(object targetResource, string propertyName, object resourceToBeAdded)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public void ClearChanges()
@@ -114,7 +114,7 @@ public object GetValue(object targetResource, string propertyName)
 
         public void RemoveReferenceFromCollection(object targetResource, string propertyName, object resourceToBeRemoved)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public object ResetResource(object targetResource)
@@ -132,7 +132,6 @@ public object ResetResource(object targetResource)
 
         public object ResolveResource(object resource)
         {
-            //we are passed the value we returned from GetResource
             return resource;
         }
 
@@ -143,12 +142,12 @@ public void SaveChanges()
 
         public void SetConcurrencyValues(object resourceCookie, bool? checkForEquality, IEnumerable<KeyValuePair<string, object>> concurrencyValues)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public void SetReference(object targetResource, string propertyName, object propertyValue)
         {
-            throw new NotImplementedException();
+            throw new NotSupportedException();
         }
 
         public void SetValue(object targetResource, string propertyName, object propertyValue)