Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composer to install CKEditor 4.X locally rather than using external CDN #279

Closed
craigk5n opened this issue Apr 7, 2022 · 0 comments
Closed

Use composer to install CKEditor 4.X locally rather than using external CDN #279

craigk5n opened this issue Apr 7, 2022 · 0 comments

Comments

@craigk5n
Copy link
Owner

craigk5n commented Apr 7, 2022

When HTML-in-descriptions is enabled in System Settings, CKEditor 4.X is included in the "Edit Entry" page. We should include CKEditor in our composer.json file and download it that way (like PHPMailer). Benefits of this:

  • Easier to update to future CKEditor versions
  • Github dependabot will notify us if a new version of CKEditor is available (and may include an PR to upgrade)
  • No references to an external CDN within WebCalendar. (I prefer WebCalendar to be self-contained so that it can be used offline on a local network.)
craigk5n added a commit that referenced this issue Apr 7, 2022
@craigk5n
Resolve issue #279: Use composer to install CKEditor 4.X locally rath…
3040f84 
…er than using external CDN #279
@craigk5n craigk5n mentioned this issue Apr 7, 2022
Merged
craigk5n added a commit that referenced this issue Apr 7, 2022
@craigk5n
Merge pull request #280 from craigk5n/ckeditor-from-composer
5921047 
Resolve issue #279: Use composer to install CKEditor 4.X locally rath…
@craigk5n craigk5n closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigk5n