Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Real Graphics modes #27

Merged
merged 3 commits into from Nov 3, 2018
Merged

Bugfix Real Graphics modes #27

merged 3 commits into from Nov 3, 2018

Conversation

craigthomas
Copy link
Owner

This PR fixes a number of bugs with real graphics modes. In particular, GxR and GxC modes were not drawing pixels correctly on the screen. This PR also implements composite artifact colors for screen mode G6R. This PR also attempts to start sorting out the PIA data direction registers as well as the PIA control registers.

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #27 into master will increase coverage by 1.09%.
The diff coverage is 11.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
+ Coverage     67.66%   68.76%   +1.09%     
+ Complexity     1025     1024       -1     
============================================
  Files            43       43              
  Lines          4856     4790      -66     
  Branches        487      432      -55     
============================================
+ Hits           3286     3294       +8     
+ Misses         1479     1405      -74     
  Partials         91       91
Impacted Files Coverage Δ Complexity Δ
.../craigthomas/yacoco3e/datatypes/G3RScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G1CScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...craigthomas/yacoco3e/datatypes/SG12ScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G2RScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G3CScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G1RScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G2CScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G6RScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../craigthomas/yacoco3e/datatypes/G6CScreenMode.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/ca/craigthomas/yacoco3e/components/CPU.java 95.62% <100%> (+0.01%) 514 <6> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181a1b4...0b4ef52. Read the comment docs.

@craigthomas craigthomas merged commit 66d0af1 into master Nov 3, 2018
@craigthomas craigthomas deleted the bugfix-sg12 branch November 10, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant