Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassette fix #28

Merged
merged 2 commits into from Nov 8, 2018
Merged

Cassette fix #28

merged 2 commits into from Nov 8, 2018

Conversation

craigthomas
Copy link
Owner

This PR fixes an issue with cassette images not having the proper EOF block at the end of the data array. All cassette tape images must have the EOF block of bytes:

`55, 3C, FF, 00, FF, 55`

A new function called checkForEOF was added to check for the proper byte pattern. The function will attempt to fix the EOF pattern so that the cassette tape will load. Unit tests added to match new functionality.

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #28 into master will increase coverage by 0.1%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #28     +/-   ##
===========================================
+ Coverage     68.76%   68.87%   +0.1%     
- Complexity     1024     1030      +6     
===========================================
  Files            43       43             
  Lines          4790     4816     +26     
  Branches        432      437      +5     
===========================================
+ Hits           3294     3317     +23     
- Misses         1405     1406      +1     
- Partials         91       93      +2
Impacted Files Coverage Δ Complexity Δ
...a/ca/craigthomas/yacoco3e/components/Cassette.java 81.81% <88.46%> (+2.05%) 33 <6> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d0af1...52f7df7. Read the comment docs.

@craigthomas craigthomas merged commit e84a17d into master Nov 8, 2018
@craigthomas craigthomas deleted the cassette-fix branch November 10, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant