Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-byte FCB declaractions #78

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Conversation

craigthomas
Copy link
Owner

This PR adds the ability to define multiple single byte declarations using a single FCB statement. Previously, all FCB statements only accepted a single byte definition. For example, to define 3 constant bytes, you would have to:

FCB $55
FCB $44
FCB 17

Now, FCB statements allow for multiple declarations per line, separated with a comma. The following would be equivalent to the code above:

FCB $55,$44,17

Unit and integration tests were added to catch new conditions. README.md documentation was updated to reference multi-byte functionality. This PR closes #53

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #78 (b8cf979) into main (0e697ba) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   94.36%   94.43%   +0.07%     
==========================================
  Files          15       15              
  Lines        1756     1779      +23     
==========================================
+ Hits         1657     1680      +23     
  Misses         99       99              
Impacted Files Coverage Δ
cocoasm/instruction.py 100.00% <100.00%> (ø)
cocoasm/operands.py 98.29% <100.00%> (+<0.01%) ⬆️
cocoasm/values.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e697ba...b8cf979. Read the comment docs.

@craigthomas craigthomas merged commit 97b8796 into main Oct 2, 2022
@craigthomas craigthomas deleted the multipart-fcb branch October 3, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple single byte definitions per FCB pseudo operation
1 participant