Fix bug where non-machine language files could not be read #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem when attempting to read file information from virtual disk. Any file type that was not marked as machine language could not be read. This was due to the fact that the virtual disk file assumed that every file had preamble and postamble information associated with it. This isn't the case with file types such as ASCII files or BASIC files. A check is now performed on the file type first before preamble or postamble data is read. A new method was introduced to calculate file size due to the fact that file size information was previously only read from the preamble. Unit tests updated to catch new conditions. This PR closes #79