Bug fixes for PSHU and PULU #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 94.78% 94.84% +0.05%
==========================================
Files 15 15
Lines 1900 1919 +19
==========================================
+ Hits 1801 1820 +19
Misses 99 99
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Update the workflow to use latest Python version. Update actions to latest versions. Try to get version names correct.
craigthomas
force-pushed
the
pshu-pulu-bugfix
branch
from
65212d9
to
f1d6833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
PSHUandPULUinstructions. Both instructions were not marked as beingis_special, nor were they handled in theSpecialOperandclass during translation. This PR puts a fix in so that both statements are now correctly handled. Regression tests added to catch conditions.In addition to those fixes, this PR also updates the Github Actions workflow file to bump versions for Python checkout and OS dependencies to their latest versions.
This PR closes issue #87