Add support for other administrative areas #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigw
added a commit
that referenced
this pull request
Sep 17, 2013
Add support for other administrative areas
|
Thank you very much! I've merged this and will release a new version ASAP. |
|
No probs! 馃槃 I've just made a tiny change to tidy the code up a bit. I'll get another PR in shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if an area is two tier, only the first authority (usually the district) is returned. This PR adds support for two tier authorities, other administrative areas, easting and northing, as well as Rspec tests.
I also noticed that the x and y coordinates were the wrong way round, so fixed that too - I think the confusion comes from the fact that Mapit expects queries in the format y,x, as opposed to the more traditional x,y.
Thoughts welcome! 馃槃