Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Puppet files plus Ubuntu 10.04 support #36

Merged
merged 12 commits into from Apr 26, 2014

Conversation

keeleysam
Copy link

This adds support for external puppet URLs, which is very useful if storing the VMware tools in another module from which this module is called. In addition, the params are rewritten to better support different versions of Ubuntu, which is needed for 10.04.

@craigwatson
Copy link
Owner

Thanks very much for the request - unfortunately your code fails a few Puppet Lint checks, would you mind fixing them before I merge?

See here for details: https://travis-ci.org/craigwatson/puppet-vmwaretools/jobs/23567201

Thanks :)

@keeleysam
Copy link
Author

This now passes lint.

@craigwatson
Copy link
Owner

Thanks - I'll revert the travis commit once I've merged - FYI you can run the lint tests locally with rake lint.

There's also a slight gotcha with quoted booleans, as facts are returned as strings - will correct that too :)

craigwatson added a commit that referenced this pull request Apr 26, 2014
External Puppet files plus Ubuntu 10.04 support
@craigwatson craigwatson merged commit 0759ad9 into craigwatson:master Apr 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants