Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-root unpacking for old systems #11

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Fix non-root unpacking for old systems #11

merged 6 commits into from
Nov 21, 2022

Conversation

Enchufa2
Copy link
Member

@grantmcdermott @philipp-baumann: Could you please try this branch?

Closes #9

@philipp-baumann
Copy link

awesome, this PR works on Rocky 8.7 with RPM version 4.14.3. On CentOS like systems with RPM v < 4.12, can cpio be expected to be installed? If no, would a short error message to install help users?

@Enchufa2
Copy link
Member Author

Enchufa2 commented Nov 21, 2022

Thanks for testing. Package cpio is expected to be available because the CentOS 7 base image has this installed, even the docker one. And I believe they implemented rpm2archive to avoid providing cpio by default. Anyways, if this is not available, an error would be issued due to https://github.com/Enchufa2/rspm/pull/11/files#diff-da37bec44282a8b2a2f78b5040c8f5d211affb10a0727d08c9a8a784c32dacf2R21

@philipp-baumann
Copy link

Thanks for testing. Package cpio is expected to be available because the CentOS 7 base image has this installed, even the docker one. And I believe they implemented rpm2archive to avoid providing cpio by default. Anyways, if this is not available, an error would be issued due to https://github.com/Enchufa2/rspm/pull/11/files#diff-da37bec44282a8b2a2f78b5040c8f5d211affb10a0727d08c9a8a784c32dacf2R21

Excellent, thanks a lot for this! Interesting note on rpm2archive.

@Enchufa2
Copy link
Member Author

I'll merge this later and send it to CRAN. Thanks again for raising this.

@Enchufa2 Enchufa2 merged commit af892c3 into main Nov 21, 2022
@Enchufa2 Enchufa2 deleted the fix/9 branch November 21, 2022 13:39
@philipp-baumann
Copy link

Neat! Quick info maybe before you update on CRAN. Just also tested on Rocky 9.0 on google cloud instance. rspm::os() resolves to "centos9", which is not resolved to correctly in the URL to packagemanager.rstudio.com. Will quickly open a spearate issue, PR should be very minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run rspm::enable() unless root
2 participants