Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating project tags on the front-end #828

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

mosesmulumba
Copy link
Collaborator

Description

This is to illustrate how the project tags will be created on the front-end, someone is able to create a tag and also remove it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Trello Ticket ID

https://trello.com/c/FKx1RvFI

How Can This Been Tested?

Fetch the remote branch "ft/project-tags" and visit the project settings and move on to the update modal, there you see an input section for project tags. Add a specific tag to your project, make sure it is not blank.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Screenshots

image

Copy link
Collaborator

@khalifan-kfan khalifan-kfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosesmulumba nice one,

Could we also have it on project creation

@khalifan-kfan
Copy link
Collaborator

Screenshot 2024-07-04 at 10 57 07

Could you also balance the button and in put at this point
Same with the tagged option, atleast aligning every thing in the center

@khalifan-kfan
Copy link
Collaborator

Also just a suggestion @rhodinemma, @Mubangizi and @mosesmulumba could this be a drop down auto complete input

@rhodinemma
Copy link
Collaborator

Also just a suggestion @rhodinemma, @Mubangizi and @mosesmulumba could this be a drop down auto complete input

Good Idea, we could explore how to have them with some sort of auto-complete to save users the hassle of entering tags that we already have in our tags collection, which would also save us the burden of them entering meaningless tags 😅
and i think the new tags endpoint is searchable, good observation @khalifan-kfan.
Screenshot 2024-07-04 at 11 35 44 AM

Screenshot 2024-07-04 at 11 32 42 AM

@mosesmulumba
Copy link
Collaborator Author

mosesmulumba commented Jul 4, 2024 via email

Copy link
Collaborator

@rhodinemma rhodinemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the feedback @mosesmulumba

@rhodinemma rhodinemma dismissed khalifan-kfan’s stale review July 5, 2024 07:30

changes were worked on.

@rhodinemma rhodinemma merged commit 4a1720a into microservice Jul 5, 2024
2 checks passed
@rhodinemma rhodinemma deleted the ft/project-tags branch July 5, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants