Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease IRAM memory pressure. #138

Closed
crankyoldgit opened this issue Apr 2, 2017 · 1 comment
Closed

Decrease IRAM memory pressure. #138

crankyoldgit opened this issue Apr 2, 2017 · 1 comment
Assignees
@crankyoldgit
Labels
enhancement

Comments

@crankyoldgit
Copy link
Owner

All routines that are not interrupt routines should have the 'ICACHE_FLASH_ATTR' attribute, to help alleviate exhausting the esp8266's iram segment.
Some reading indicates that routines that don't have that attribute specified default to iram. Most of the library isn't time critical, except for the interrupt routines, thus we should add this to pretty much every function etc. and be good ram citizens.

Some reference docs here: http://bbs.espressif.com/viewtopic.php?t=1183 & http://www.esp8266.com/viewtopic.php?f=9&t=12754

Issue was highlighted in letscontrolit/ESPEasy#188
@crankyoldgit crankyoldgit self-assigned this Apr 2, 2017
@crankyoldgit crankyoldgit mentioned this issue Apr 2, 2017
Merged
@crankyoldgit
Copy link
Owner Author

Note: Requires code to have ICACHE_FLASH defined (compiled with -DICACHE_FLASH) in order to be enacted.

FYI for @psy0rz

@crankyoldgit crankyoldgit mentioned this issue Apr 10, 2017
Merged
Repository owner locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crankyoldgit