Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request code to be run from flash, rather than iram. #139

Merged
merged 1 commit into from
Apr 2, 2017
Merged

Request code to be run from flash, rather than iram. #139

merged 1 commit into from
Apr 2, 2017

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Apr 2, 2017 •
edited
Loading

See #138 for details.

@crankyoldgit crankyoldgit self-assigned this Apr 2, 2017
markszabo
markszabo approved these changes Apr 2, 2017
View reviewed changes
Copy link
Collaborator

@markszabo markszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@crankyoldgit
Copy link
Owner Author

Note: Requires code to have ICACHE_FLASH defined (compiled with -DICACHE_FLASH) in order to be enacted.

FYI for @psy0rz

@crankyoldgit crankyoldgit merged commit 8760723 into crankyoldgit:master Apr 2, 2017
@crankyoldgit crankyoldgit deleted the add_icache_flash branch April 2, 2017 09:21
@crankyoldgit crankyoldgit added this to Done in v2.0 Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markszabo markszabo markszabo approved these changes

@roidayan roidayan Awaiting requested review from roidayan

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
No open projects
v2.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crankyoldgit @markszabo