Argo Ulisse 13 IR messages not decoding correctly #1859

zpin · 2022-08-18T08:46:13Z

Version/revision of the library used

2.8.2/master

Describe the bug

IR messages captured from an Argo Ulisse 13 remote are not detected as such. Also there seem to be messages of different length while the library only tries to match the longer ones.

To Reproduce

Use IRremoteESP8266: IRrecvDumpV2 to capture messages

Output of raw data from IRrecvDumpV2.ino or V3 (if applicable)

10:18:33.818 -> Library   : v2.8.2
Manual ON
10:18:33.818 -> Protocol  : UNKNOWN
10:18:33.818 -> Code      : 0x5D1B22E5 (92 Bits)
10:18:33.818 -> uint16_t rawData[183] = {6418, 3168,  442, 836,  442, 834,  442, 2114,  442, 2114,  442, 836,  442, 2114,  442, 836,  440, 2114,  442, 2114,  442, 836,  442, 2112,  442, 834,  442, 2112,  442, 2112,  444, 2112,  442, 2114,  442, 836,  442, 836,  442, 834,  442, 834,  442, 2112,  442, 836,  442, 834,  442, 836,  440, 2114,  442, 836,  440, 2114,  442, 836,  442, 836,  440, 836,  442, 2112,  442, 2114,  442, 836,  442, 2114,  442, 2114,  442, 836,  442, 836,  442, 836,  440, 836,  442, 836,  442, 836,  442, 836,  442, 836,  440, 836,  442, 836,  440, 2114,  442, 2114,  442, 2114,  442, 836,  440, 838,  440, 836,  442, 836,  440, 838,  440, 836,  440, 836,  440, 836,  442, 2114,  440, 2116,  440, 2114,  442, 2114,  440, 2114,  440, 2114,  442, 2114,  442, 836,  440, 2114,  440, 836,  442, 2114,  442, 836,  440, 836,  442, 836,  442, 836,  440, 836,  440, 836,  440, 836,  440, 836,  440, 836,  440, 836,  440, 2114,  442, 836,  440, 2114,  442, 836,  440, 2114,  442, 836,  440, 2116,  440, 836,  440, 836,  440, 836,  440, 836,  442, 836,  440, 2114,  442};  // UNKNOWN 5D1B22E5

Manual OFF
10:18:40.641 -> Protocol  : UNKNOWN
10:18:40.641 -> Code      : 0x4162A6F0 (92 Bits)
10:18:40.641 -> uint16_t rawData[183] = {6384, 3206,  414, 864,  414, 864,  412, 2144,  412, 2142,  412, 864,  412, 2142,  414, 864,  412, 2144,  412, 2144,  410, 866,  412, 2142,  412, 866,  412, 2142,  412, 2144,  412, 2144,  412, 2170,  386, 866,  412, 864,  412, 866,  410, 866,  412, 2144,  412, 866,  412, 864,  412, 864,  412, 2144,  410, 866,  412, 2144,  412, 890,  386, 864,  412, 866,  412, 2144,  410, 2144,  412, 866,  410, 2172,  386, 2168,  386, 892,  360, 916,  386, 892,  386, 892,  386, 892,  386, 890,  386, 892,  384, 892,  386, 868,  408, 892,  386, 2170,  386, 2170,  384, 2170,  384, 892,  384, 892,  362, 916,  384, 892,  360, 916,  360, 916,  360, 916,  360, 918,  360, 2194,  360, 2194,  362, 2194,  386, 2170,  360, 2196,  360, 2196,  358, 2196,  360, 916,  384, 2172,  360, 918,  360, 2194,  360, 918,  358, 918,  362, 916,  360, 918,  360, 918,  360, 918,  360, 918,  360, 918,  360, 916,  360, 918,  360, 916,  360, 918,  360, 2196,  360, 918,  360, 2194,  362, 916,  360, 2196,  360, 918,  360, 918,  360, 918,  360, 2196,  360, 2196,  360, 918,  360};  // UNKNOWN 4162A6F0

Manual target temperature change 24->25
10:19:45.713 -> Protocol  : UNKNOWN
10:19:45.713 -> Code      : 0xD21627D (93 Bits)
10:19:45.713 -> uint16_t rawData[185] = {634, 402,  5320, 3258,  362, 916,  360, 916,  384, 2144,  412, 2170,  386, 892,  384, 2170,  360, 916,  360, 2194,  384, 2170,  360, 916,  362, 2194,  360, 916,  360, 2194,  362, 2194,  362, 2194,  360, 2168,  388, 916,  360, 916,  360, 916,  360, 916,  362, 2194,  360, 916,  362, 2194,  360, 916,  360, 2196,  360, 918,  360, 2194,  360, 918,  360, 916,  360, 918,  360, 2194,  360, 2194,  362, 916,  360, 2196,  360, 2194,  362, 916,  360, 916,  360, 918,  358, 918,  360, 918,  360, 916,  360, 918,  360, 918,  360, 916,  360, 918,  360, 2196,  358, 2196,  360, 2196,  360, 918,  358, 918,  360, 918,  360, 918,  360, 918,  360, 918,  360, 918,  360, 918,  358, 2196,  360, 2196,  360, 2196,  360, 918,  358, 918,  358, 918,  362, 916,  360, 2196,  358, 2196,  360, 918,  358, 2196,  358, 918,  360, 918,  358, 918,  358, 918,  358, 918,  360, 918,  360, 918,  358, 918,  358, 920,  358, 918,  358, 2198,  358, 918,  358, 2196,  358, 918,  358, 2196,  358, 1010,  268, 2198,  358, 920,  356, 2198,  358, 920,  358, 1010,  266, 2198,  358, 2198,  358};  // UNKNOWN D21627D

Manual target temperature change 25->24
10:20:14.030 -> Protocol  : UNKNOWN
10:20:14.030 -> Code      : 0xE923CB07 (92 Bits)
10:20:14.030 -> uint16_t rawData[183] = {6386, 3206,  414, 862,  416, 862,  414, 2140,  414, 2140,  414, 862,  416, 2140,  414, 864,  414, 2140,  414, 2142,  414, 862,  414, 2142,  414, 864,  414, 2142,  414, 2142,  414, 2142,  414, 2140,  414, 862,  414, 864,  414, 862,  414, 864,  414, 2142,  414, 864,  412, 862,  416, 862,  414, 2142,  414, 864,  412, 2142,  414, 864,  414, 866,  412, 864,  412, 2142,  414, 2142,  414, 864,  412, 2142,  412, 2142,  412, 864,  414, 862,  414, 864,  414, 864,  412, 864,  412, 864,  414, 888,  388, 874,  404, 864,  414, 890,  386, 2142,  414, 2142,  412, 2142,  412, 866,  412, 890,  388, 890,  386, 890,  388, 890,  388, 890,  386, 866,  412, 890,  388, 2168,  388, 2168,  388, 2168,  386, 890,  386, 890,  386, 890,  386, 890,  386, 2168,  388, 2168,  388, 890,  386, 2168,  386, 892,  386, 890,  386, 890,  386, 890,  388, 890,  386, 892,  386, 890,  386, 892,  386, 890,  386, 890,  386, 2170,  386, 892,  386, 2170,  386, 890,  386, 2170,  386, 890,  386, 2170,  386, 892,  386, 2170,  386, 890,  386, 892,  386, 890,  386, 2170,  386};  // UNKNOWN E923CB07

Manual target temperature change 24->25
10:42:12.339 -> Protocol  : UNKNOWN
10:42:12.339 -> Code      : 0x2D0000E3 (92 Bits)
10:42:12.339 -> uint16_t rawData[183] = {6418, 3168,  442, 834,  442, 834,  442, 2112,  444, 2112,  444, 832,  444, 2112,  444, 834,  442, 2112,  444, 2112,  442, 834,  444, 2112,  444, 834,  442, 2112,  442, 2112,  442, 2112,  444, 2112,  444, 834,  444, 834,  442, 834,  442, 834,  442, 2112,  444, 834,  444, 2112,  444, 834,  442, 2112,  442, 834,  442, 2112,  442, 836,  442, 834,  442, 2112,  444, 2112,  442, 2112,  442, 834,  442, 2112,  444, 2112,  442, 834,  442, 834,  442, 834,  444, 834,  442, 834,  442, 834,  442, 836,  442, 834,  442, 834,  442, 836,  442, 2112,  442, 2112,  444, 2112,  442, 836,  442, 834,  442, 834,  442, 834,  442, 836,  442, 836,  442, 834,  442, 836,  442, 2114,  442, 2112,  442, 2112,  442, 834,  442, 2112,  442, 2114,  442, 834,  442, 836,  442, 836,  442, 2112,  442, 2112,  442, 834,  442, 836,  442, 836,  442, 834,  442, 836,  442, 836,  442, 836,  442, 836,  442, 836,  442, 836,  442, 2114,  442, 836,  440, 2114,  442, 836,  442, 2114,  442, 2114,  442, 2114,  442, 836,  440, 2114,  442, 2114,  442, 836,  442, 836,  440, 2114,  442};  // UNKNOWN 2D0000E3

Silent temperature message 30C:
10:22:04.919 -> Protocol  : UNKNOWN
10:22:04.919 -> Code      : 0x936639B2 (34 Bits)
10:22:04.919 -> uint16_t rawData[67] = {6386, 3204,  414, 862,  416, 862,  414, 2140,  414, 2140,  414, 864,  414, 2140,  416, 862,  414, 2140,  416, 2140,  416, 862,  414, 2142,  414, 864,  414, 2142,  414, 2140,  414, 2142,  414, 2142,  414, 862,  414, 2142,  416, 862,  414, 864,  414, 2140,  414, 862,  414, 2142,  414, 2142,  414, 2142,  412, 2142,  414, 864,  412, 864,  414, 2142,  412, 2144,  412, 2142,  414, 864,  412};  // UNKNOWN 936639B2

Silent temperature message 29C:
10:23:09.423 -> Protocol  : UNKNOWN
10:23:09.423 -> Code      : 0x716DD4C0 (34 Bits)
10:23:09.423 -> uint16_t rawData[67] = {6420, 3168,  442, 834,  442, 834,  442, 2112,  444, 2112,  442, 834,  442, 2112,  444, 834,  442, 2112,  442, 2112,  442, 834,  444, 2112,  442, 834,  442, 2112,  442, 2114,  442, 2112,  442, 2112,  442, 836,  442, 2112,  444, 836,  442, 2112,  444, 834,  442, 836,  442, 2112,  442, 2114,  442, 2112,  442, 2112,  442, 834,  442, 2114,  442, 836,  442, 2112,  442, 2114,  442, 836,  442};  // UNKNOWN 716DD4C0

Silent temperature message 28C:
10:27:22.916 -> Protocol  : UNKNOWN
10:27:22.916 -> Code      : 0x6149090 (34 Bits)
10:27:22.916 -> uint16_t rawData[67] = {6418, 3168,  444, 834,  444, 834,  442, 2112,  444, 2112,  444, 834,  442, 2114,  442, 834,  442, 2112,  444, 2112,  444, 832,  442, 2114,  442, 834,  442, 2112,  442, 2114,  442, 2112,  444, 2112,  442, 834,  442, 2112,  444, 834,  442, 834,  442, 834,  442, 834,  442, 2114,  442, 2114,  442, 2112,  442, 2112,  442, 834,  444, 834,  442, 834,  442, 2112,  442, 2112,  442, 836,  442};  // UNKNOWN 6149090

Circuit diagram and hardware used (if applicable)

https://www.wemos.cc/en/latest/d1/d1_mini.html
https://www.wemos.cc/en/latest/d1_mini_shield/ir.html

I have followed the steps in the Troubleshooting Guide & read the FAQ

Yes

Has this library/code previously worked as expected for you?

No

The text was updated successfully, but these errors were encountered:

When using the iFeel functionality the remote regularly sends silent (i.e. no beep) messages to the Argo unit to update the current temperature. This function adds the ability to send such messages. On a side note, to capture normal Argo IR messages using IRrecv::decodeArgo I had to reduce kArgoBits and disable the checksum, likely because the message wasn't fully recorded. To capture these temperature messages I had to use nbits = 32. X-Ref: #1859

* Add `getSensorTemp()`. * deduplicate code used. * Support decoding 32bit `ARGO` messages. For #1859

crankyoldgit · 2022-08-21T14:00:39Z

@zpin Can you please download and try branch Issue1859 https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1859 and let me know how it goes.

It should decode the (very) short messages now. It doesn't do everything yet.
I've also tried to use more common code for your sendSensorTemp() too. So please re-test that too.

Also, can you determine the minimum and maximum for the sensor temp from the remote?
e.g. Put it in the fridge/freezer to get the minimum temp. Maybe a hairdryer for the maximum.

zpin · 2022-08-23T08:50:47Z

Seems to work fine from what I can tell. It's hard to test exactly because there's no acknowledgement and the unit takes several minutes to react to a change. It also manages to decode the temperature messages but still doesn't recognize the normal messages.

Temperature range looks like [5...35] celsius.
Capture starting at 29, heating up (40+ C I'd say), then letting cool down:
tmphigh.txt
Capture starting at <0 C, then letting warm up:
tmplow.txt

crankyoldgit · 2022-08-23T08:57:04Z

Looking at that data, it seems 35C is the max sensor temp recorded, and the lowest is 5C.

I'll look at adding the appropriate limits to sendSensorTemp() so we don't have anything go terribly wrong.

Thanks for confirming the sensor temps are being detected.

Plus some minor code & style cleanups. For #1859

crankyoldgit · 2022-08-23T09:42:48Z

I've added bounds checking to that funtion, so we don't get any unexpected results.
FWIW, mathematically the minimum sensor temp looks like it could be 4C. So I've allowed that.
Branch updated etc.

Now, what is the deal with the rest of the messages.

What messages are correctly decoded & which ones are not?

Also, can you please provide all the brand/model numbers of the remote and the A/C unit?

The A/C support for this protocol was user submitted code. So it doesn't have the same level of unit test coverage/support and confidence. (i.e. I can't verify that it works fully)

zpin · 2022-08-23T11:57:51Z

It's a AxAir Ulisse 13 DCI ECO and the remote says SAC WREM-2 V1. It looks like it comes under different brands (Argo, AxAir, Krueger, AirBlue, ...), as Ulisse 13 DCI ECO but there's others that look exactly the same, e.g. Technibel SCDF32 4000W, Climia CMK 4000.

It might have been an incomplete capture before, it does show ARGO now but the sensor temp is wrong, it should use the RoomTemp from these messages instead. Also, these messages are not 32bit but somewhere around 90-96 (96 according to the size of the state struct but that didn't capture correctly before). I suspect the temperature messages might also be longer but maybe don't get recorded correctly because they are mostly empty.

Here's a few captures of normal remote functions:

ON:
13:48:02.392 -> Timestamp : 000090.093
13:48:02.392 -> Library   : v2.8.2
13:48:02.392 -> 
13:48:02.392 -> Protocol  : ARGO
13:48:02.392 -> Code      : 0xACF5D0E4 (32 Bits)
13:48:02.392 -> Mesg Desc.: Sensor Temp: 30C
13:48:02.392 -> uint16_t rawData[183] = {6418, 3168,  442, 836,  440, 836,  440, 2114,  440, 2114,  442, 836,  440, 2114,  440, 836,  442, 2114,  442, 2114,  440, 836,  440, 2114,  442, 836,  440, 2114,  442, 2114,  442, 2114,  442, 2114,  442, 836,  440, 836,  442, 836,  440, 836,  440, 2114,  440, 838,  440, 2114,  442, 2114,  440, 836,  440, 836,  442, 2114,  440, 836,  440, 836,  442, 2114,  440, 2116,  440, 2114,  440, 836,  440, 2114,  442, 2114,  440, 836,  440, 838,  440, 838,  440, 836,  440, 836,  440, 836,  440, 836,  442, 836,  438, 838,  440, 836,  440, 2114,  440, 2114,  440, 2114,  440, 838,  440, 838,  440, 836,  440, 838,  440, 838,  440, 838,  440, 836,  440, 838,  440, 2116,  440, 2114,  440, 2116,  440, 838,  440, 838,  438, 838,  440, 836,  440, 838,  440, 838,  438, 838,  438, 2116,  440, 2114,  440, 838,  440, 838,  438, 838,  440, 838,  440, 838,  438, 840,  438, 838,  440, 838,  440, 838,  440, 2116,  440, 838,  438, 2116,  440, 838,  440, 2116,  440, 838,  440, 838,  438, 838,  438, 838,  438, 2116,  440, 2116,  438, 2116,  440, 2116,  438};  // ARGO
13:48:02.491 -> uint8_t state[4] = {0xAC, 0xF5, 0xD0, 0xE4};
13:48:02.491 -> 
13:48:02.491 -> 

OFF:
13:48:04.312 -> Timestamp : 000092.033
13:48:04.312 -> Library   : v2.8.2
13:48:04.312 -> 
13:48:04.312 -> Protocol  : ARGO
13:48:04.312 -> Code      : 0xACF5D0E4 (32 Bits)
13:48:04.312 -> Mesg Desc.: Sensor Temp: 30C
13:48:04.345 -> uint16_t rawData[183] = {6418, 3170,  440, 838,  438, 838,  438, 2114,  440, 2114,  440, 866,  412, 2114,  440, 840,  438, 2114,  440, 2114,  440, 864,  412, 2114,  442, 864,  412, 2114,  442, 2114,  440, 2116,  440, 2114,  440, 866,  412, 866,  412, 866,  412, 866,  412, 2116,  440, 864,  412, 2116,  440, 2114,  440, 866,  412, 866,  412, 2116,  440, 866,  412, 866,  412, 2116,  440, 2114,  440, 2116,  440, 866,  412, 2114,  440, 2116,  440, 866,  412, 864,  412, 866,  412, 864,  412, 864,  412, 866,  410, 866,  410, 866,  412, 866,  410, 864,  412, 2116,  440, 2116,  440, 2116,  440, 866,  410, 866,  412, 866,  412, 866,  412, 866,  412, 866,  410, 866,  412, 866,  412, 2116,  440, 2116,  440, 2114,  440, 866,  412, 866,  412, 866,  410, 866,  412, 866,  410, 866,  412, 866,  412, 2116,  440, 2116,  438, 866,  412, 866,  412, 866,  412, 866,  412, 866,  412, 866,  412, 866,  412, 866,  412, 866,  410, 866,  412, 866,  412, 2116,  438, 866,  410, 2116,  440, 866,  410, 866,  410, 866,  412, 866,  410, 2116,  438, 868,  410, 2116,  438, 2116,  438};  // ARGO
13:48:04.412 -> uint8_t state[4] = {0xAC, 0xF5, 0xD0, 0xE4};
13:48:04.412 -> 
13:48:04.412 -> 

ON:
13:48:06.233 -> Timestamp : 000093.964
13:48:06.233 -> Library   : v2.8.2
13:48:06.266 -> 
13:48:06.266 -> Protocol  : ARGO
13:48:06.266 -> Code      : 0xACF5D0E4 (32 Bits)
13:48:06.266 -> Mesg Desc.: Sensor Temp: 30C
13:48:06.266 -> uint16_t rawData[183] = {6418, 3168,  440, 836,  440, 836,  442, 2114,  440, 2114,  442, 836,  440, 2114,  440, 836,  440, 2114,  442, 2114,  440, 836,  440, 2114,  440, 838,  440, 2114,  442, 2114,  442, 2114,  440, 2114,  440, 838,  440, 838,  440, 836,  440, 836,  440, 2114,  440, 836,  440, 2114,  440, 2116,  440, 838,  440, 838,  440, 2114,  440, 838,  440, 836,  440, 2116,  440, 2114,  440, 2116,  440, 838,  440, 2116,  440, 2114,  440, 838,  438, 838,  438, 838,  440, 838,  440, 838,  438, 838,  440, 838,  440, 838,  438, 840,  438, 838,  438, 2116,  440, 2116,  440, 2116,  440, 838,  438, 838,  438, 838,  438, 866,  412, 840,  438, 840,  438, 864,  412, 840,  438, 2116,  440, 2116,  440, 2116,  440, 840,  438, 840,  438, 866,  412, 838,  440, 864,  412, 866,  410, 866,  412, 2116,  440, 2116,  438, 866,  412, 866,  410, 866,  412, 866,  412, 866,  410, 866,  410, 866,  410, 866,  410, 866,  412, 2116,  438, 866,  412, 2116,  440, 866,  410, 2116,  440, 866,  412, 866,  412, 866,  412, 866,  410, 2116,  440, 2116,  440, 2116,  438, 2116,  438};  // ARGO
13:48:06.365 -> uint8_t state[4] = {0xAC, 0xF5, 0xD0, 0xE4};
13:48:06.365 -> 
13:48:06.365 -> 

Change target temperature from 23 to 24:
13:48:10.107 -> Timestamp : 000097.822
13:48:10.107 -> Library   : v2.8.2
13:48:10.107 -> 
13:48:10.107 -> Protocol  : ARGO
13:48:10.107 -> Code      : 0xACF510E5 (32 Bits)
13:48:10.107 -> Mesg Desc.: Sensor Temp: 6C
13:48:10.107 -> uint16_t rawData[183] = {6420, 3168,  442, 836,  440, 838,  440, 2114,  442, 2114,  442, 836,  440, 2114,  442, 836,  440, 2114,  440, 2114,  440, 836,  440, 2114,  440, 836,  442, 2114,  440, 2116,  440, 2114,  440, 2114,  440, 838,  440, 836,  440, 838,  440, 838,  440, 2116,  440, 838,  440, 836,  440, 838,  440, 2116,  440, 838,  440, 2114,  440, 838,  440, 838,  440, 2114,  440, 2114,  442, 2114,  440, 838,  440, 2114,  440, 2114,  442, 836,  440, 838,  438, 838,  438, 838,  438, 838,  438, 838,  440, 838,  438, 838,  440, 838,  438, 838,  440, 2116,  440, 2114,  440, 2114,  440, 838,  438, 840,  438, 838,  438, 840,  438, 838,  438, 838,  438, 838,  438, 840,  438, 2116,  440, 2114,  440, 2116,  440, 840,  438, 840,  438, 838,  438, 840,  438, 864,  412, 840,  438, 840,  438, 2116,  440, 2116,  440, 866,  412, 866,  412, 866,  410, 866,  412, 866,  412, 864,  412, 866,  412, 866,  410, 866,  410, 2116,  440, 866,  412, 2116,  440, 866,  412, 2116,  438, 2116,  440, 866,  410, 866,  412, 866,  410, 2116,  438, 2116,  440, 866,  412, 866,  412};  // ARGO
13:48:10.207 -> uint8_t state[4] = {0xAC, 0xF5, 0x10, 0xE5};
13:48:10.207 -> 
13:48:10.207 ->

_v2.8.3 (20220915)_ **[Bug Fixes]** - Fix `#if` for DECODE_COOLIX48 (#1796) - Add missing `prev`s to `decodeToState()` (#1783) **[Features]** - Add `pause()` function to ESP32 when receiving. (#1871) - ARGO: Argo add `sendSensorTemp()` (#1858 #1859) - HAIER_AC160: Experimental detail support. (#1852 #1804) - BOSCH144: Add IRac class support (#1841) - Mitsubishi_AC: update left vane in `IRac` class (#1837) - Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829) - Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826) - GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821) - Experimental basic support for Bosch 144bit protocol. (#1822 #1787) - Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810) - Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812) - TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806) - CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797) - HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804) - DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802) - FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780) - FUJITSU: Improve handling of short (command only) messages. (#1784 #1780) **[Misc]** - Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870) - SONY: Update supported devices. (#1872) - SAMSUNG: Update supported devices (#1873) - NEC: Update supported devices (#1874) - Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851) - Inhibit protocol names for not-included protocols (#1853 #1851) - Test out codeql static analysis (#1842) - Remove pylint disable=no-self-use (#1817) - Fujitsu General: update supported devices (#1813) - DAIKIN: Update supported devices (#1808 #1807) - Fujitsu: Update supported remote info. (#1801 #1794) - DAIKIN128: Update supported devices (#1754) - Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238) - Daikin128: Additional unit test. (#1795 #1754) - MIDEA: Update supported devices (#1791 #1790)

**_v2.8.3 (20220915)_** **[Bug Fixes]** - Fix `#if` for DECODE_COOLIX48 (#1796) - Add missing `prev`s to `decodeToState()` (#1783) **[Features]** - Add `pause()` function to ESP32 when receiving. (#1871) - ARGO: Argo add `sendSensorTemp()` (#1858 #1859) - HAIER_AC160: Experimental detail support. (#1852 #1804) - BOSCH144: Add IRac class support (#1841) - Mitsubishi_AC: update left vane in `IRac` class (#1837) - Basic support for Daikin 312bit/39byte A/C protocol. (#1836 #1829) - Experimental basic support for Sanyo AC 152 bit protocol. (#1828 #1826) - GREE: Add model support for `YX1FSF`/Soleus Air Windown A/C (#1823 #1821) - Experimental basic support for Bosch 144bit protocol. (#1822 #1787) - Experimental basic support for TCL AC 96 bit protocol. (#1820 #1810) - Add basic support for clima-butler (52bit) RCS-SD43UWI (#1815 #1812) - TOTO: An experimental _(s)wipe_ at support for Toto Toilets. (#1811 #1806) - CARRIER_AC128: Experimental Basic support for Carrier AC 128bit protocol. (#1798 #1797) - HAIER_AC160: Add basic support for Haier 160bit protocol. (#1805 #1804) - DAIKIN: Add basic support for 200-bit Daikin protocol. (#1803 #1802) - FUJITSU: Improve handling of 10C Heat mode. (#1788 #1780) - FUJITSU: Improve handling of short (command only) messages. (#1784 #1780) **[Misc]** - Improve the `_IRREMOTEESP8266_VERSION_VAL` macro (#1875 #1870) - SONY: Update supported devices. (#1872) - SAMSUNG: Update supported devices (#1873) - NEC: Update supported devices (#1874) - Give IRmacros.h smaller scope to avoid impacting projects using IRremoteESP8266 (#1857 #1853 #1851) - Inhibit protocol names for not-included protocols (#1853 #1851) - Test out codeql static analysis (#1842) - Remove pylint disable=no-self-use (#1817) - Fujitsu General: update supported devices (#1813) - DAIKIN: Update supported devices (#1808 #1807) - Fujitsu: Update supported remote info. (#1801 #1794) - DAIKIN128: Update supported devices (#1754) - Voltas: Add link to manual for 122LZF A/C. (#1800 #1799 #1238) - Daikin128: Additional unit test. (#1795 #1754) - MIDEA: Update supported devices (#1791 #1790)

* Add `getSensorTemp()`. * deduplicate code used. * Support decoding 32bit `ARGO` messages. For crankyoldgit#1859

Plus some minor code & style cleanups. For crankyoldgit#1859

mbronk · 2022-10-16T17:33:07Z

Hi,
I'm currently in process of adding support for what seems to be next generation of this remote (WREM-3 - it's capacitive btn./touch-based, see: https://argoclima.com/en/prodotti/argo-ulisse-eco/ ).
While at it, I figured I could extract/reuse common code, but unfortunately as I don't own a WREM-2 remote, so probably won't be able to refactor the code too much.
From what I gathered, the new remote seems to have a slightly different AC protocol (message lengths, checksums calculated differently...), but seems to have quite a few similarities as well.

For example, the new remote has 4 types of commands:

[0b00] Regular/operation - 6-byte IR command (AC operation, like on/off, temp set...)
[0b01] iFeel Temperature report - 2-byte IR command (temp+3-bit checksum)
[0b10] Timer command - 9-byte
[0b11] Config command - 4-byte

Am I reading it correctly that for WREM-2, "regular" + "timer" is actually one jumbo command, and "config" does not exist at all?

If someone who owns this remote could confirm it would help me decide how much is there to reuse. Thx in advance!

mbronk · 2022-10-16T22:23:11Z

On another note... the IRArgoAC::sendSensorTemp() method which sends the (shorter) iFeel report is only exposed from IRArgoAC itself. I would really like for this to be exposed through

IRremoteESP8266/src/IRac.h

Line 74 in 9228143

bool sendAc(const stdAc::state_t desired, const stdAc::state_t *prev = NULL);

... which would allow for a generic interface, and straightforward use in downstream projects, like Tasmota IR, for example (e.g. somewhere here).

Extending stdAc::state_t to sth like

struct state_t {
  // (...) existing fields
  float sensorTemp = -1.0;  // -1 for not present
                            // consider: std:optional<>, when project moves to c++17
};

seems straightforward enough (esp. since I see that lot of AC protocols have iFeel and getSensorTemp() / setSensorTemp(...).

What I struggle with, is - given Argo sends separate commands (e.g. 4B for iFeel report as per my post above) - how should the generic i-face allow the user to choose what they want? (it's an either-or choice for this protocol).
Naive implementation: (if sensorTemp is set -> send it and disregard any other state param) would work, but is not exactly scalable nor explicit. On the other hand, translating one sendAc(...) invocation into, potentially, a series of 1..4 commands does not seem to be too intuitive either :(

@crankyoldgit do you have a preference or pointers here? Is something like this being done anywhere in the library already?

mbronk · 2022-10-22T10:49:23Z

Sorry for the churn...
@crankyoldgit - are you by any chance planning to merge Issue1859 branch anytime soon?

I'm adding the WREM3 remote support (new Argo remote type) and, while the code would be mostly addon on top of what is there, there is a common part I'm touching as well. For now I've branched off of Issue1859 to minimize merge conflicts, but can also base off of master if the former is not going to be merged soon.
I hope to have my PR ready this or next weekend, likely. Please advise

crankyoldgit · 2022-10-22T11:02:26Z

Apologies. I had forgotten about that branch. No sure were I was/am with that. Created PR #1906 to merge it in.

* ARGO: Improve code & add support for decoding 32bit sensor msgs. * Add `getSensorTemp()`. * deduplicate code used. * Support decoding 32bit `ARGO` messages. * Add bounds checking to `sendSensorTemp()` Plus some minor code & style cleanups. For #1859

crankyoldgit · 2022-10-22T16:53:45Z

@mbronk it's now merged

_v2.8.5 (20230305)_ **[Bug Fixes]** - Missing argument in use of midea function (#1959 #1958) - IRMQTTServer: Improve HA MQTT climate handling. (#1911) - SEND_SANYO_AC88: Fix poor cut-n-paste error (#1905 #1897) **[Features]** - IRMQTTServer: SHT-3x Temperature Sensor Support (#1951) - IRMQTTServer: HA multi output discovery (#1947) - IRMQTTServer: extended with new A/C common fields (#1940) - IRMQTTServer: Sync the on state to power from mode for HA (#1946) - Experimental basic support for Carrier 84-bit protocol. (#1945 #1943) - Add support the WowWee 11-Bit RoboRaptor-X protocol. (#1939 #1938) - Added 'sensorTemperature' and 'iFeel' to IRac (common) (#1928) - Added extra 'mid' option for Fan & SwingV to IRac (#1929) - Added "commandType" to IRAc (#1921) - Added support for Argo WREM-3 A/C remote protocol [part1] (#1920) - Added Dutch (nl-NL) translation (#1907) - ARGO: Improve code & add support for decoding 32bit sensor msgs. (#1906 #1859) - Added support for Gorenje cooker hood IR protocol (#1888 #1887) **[Misc]** - Update `XMP` status to Stable (#1944) - upgrade to a later version of `googletest` (#1936) - MITSUBISHI128: Added model to supported protocol (#1924) - Added Dutch (nl-NL) README (#1908) - Added GMock to UT Makefile (#1902) - Update HA example config for HA 2022.6+ (#1901 #1900)

@1976

_v2.8.5 (20230508)_ **[Bug Fixes]** - Fix a bug where we never detached the timer interrupt on ESP32s. (#1984 #1983) - Missing argument in use of midea function (#1959 #1958) - IRMQTTServer: Improve HA MQTT climate handling. (#1911) - SEND_SANYO_AC88: Fix poor cut-n-paste error (#1905 #1897) **[Features]** - Add support for a 40bit variant of the standard Panasonic protocol (#1977 @1976) - Initial support for York AC protocol (#1889) - IRMQTTServer: SHT-3x Temperature Sensor Support (#1951) - IRMQTTServer: HA multi output discovery (#1947) - IRMQTTServer: extended with new A/C common fields (#1940) - IRMQTTServer: Sync the on state to power from mode for HA (#1946) - Experimental basic support for Carrier 84-bit protocol. (#1945 #1943) - Add support the WowWee 11-Bit RoboRaptor-X protocol. (#1939 #1938) - Added 'sensorTemperature' and 'iFeel' to IRac (common) (#1928) - Added extra 'mid' option for Fan & SwingV to IRac (#1929) - Added "commandType" to IRAc (#1921) - Added support for Argo WREM-3 A/C remote protocol [part1] (#1920) - Added Dutch (nl-NL) translation (#1907) - ARGO: Improve code & add support for decoding 32bit sensor msgs. (#1906 #1859) - Added support for Gorenje cooker hood IR protocol (#1888 #1887) **[Misc]** - Add Electrolux YKR-H/531E as a supported device (#1981 #1980) - Update `XMP` status to Stable (#1944) - upgrade to a later version of `googletest` (#1936) - MITSUBISHI128: Added model to supported protocol (#1924) - Added Dutch (nl-NL) README (#1908) - Added GMock to UT Makefile (#1902) - Update HA example config for HA 2022.6+ (#1901 #1900) - Add a `d1_mini_noMDNS` build option to `IRMQTTServer`. (#1985)

@1976

## _v2.8.5 (20230508)_ **[Bug Fixes]** - Fix a bug where we never detached the timer interrupt on ESP32s. (#1984 #1983) - Missing argument in use of midea function (#1959 #1958) - IRMQTTServer: Improve HA MQTT climate handling. (#1911) - SEND_SANYO_AC88: Fix poor cut-n-paste error (#1905 #1897) **[Features]** - Add support for a 40bit variant of the standard Panasonic protocol (#1977 @1976) - Initial support for York AC protocol (#1889) - IRMQTTServer: SHT-3x Temperature Sensor Support (#1951) - IRMQTTServer: HA multi output discovery (#1947) - IRMQTTServer: extended with new A/C common fields (#1940) - IRMQTTServer: Sync the on state to power from mode for HA (#1946) - Experimental basic support for Carrier 84-bit protocol. (#1945 #1943) - Add support the WowWee 11-Bit RoboRaptor-X protocol. (#1939 #1938) - Added 'sensorTemperature' and 'iFeel' to IRac (common) (#1928) - Added extra 'mid' option for Fan & SwingV to IRac (#1929) - Added "commandType" to IRAc (#1921) - Added support for Argo WREM-3 A/C remote protocol [part1] (#1920) - Added Dutch (nl-NL) translation (#1907) - ARGO: Improve code & add support for decoding 32bit sensor msgs. (#1906 #1859) - Added support for Gorenje cooker hood IR protocol (#1888 #1887) **[Misc]** - Add Electrolux YKR-H/531E as a supported device (#1981 #1980) - Update `XMP` status to Stable (#1944) - upgrade to a later version of `googletest` (#1936) - MITSUBISHI128: Added model to supported protocol (#1924) - Added Dutch (nl-NL) README (#1908) - Added GMock to UT Makefile (#1902) - Update HA example config for HA 2022.6+ (#1901 #1900) - Add a `d1_mini_noMDNS` build option to `IRMQTTServer`. (#1985)

crankyoldgit self-assigned this Aug 21, 2022

crankyoldgit added the enhancement label Aug 21, 2022

crankyoldgit added a commit that referenced this issue Aug 21, 2022

ARGO: Improve code & add support for decoding 32bit sensor msgs.

5396d5d

* Add `getSensorTemp()`. * deduplicate code used. * Support decoding 32bit `ARGO` messages. For #1859

crankyoldgit added more info Pending Confirmation Waiting for confirmation from user labels Aug 21, 2022

crankyoldgit added a commit that referenced this issue Aug 23, 2022

Add bounds checking to sendSensorTemp()

dd860e7

Plus some minor code & style cleanups. For #1859

crankyoldgit mentioned this issue Sep 15, 2022

v2.8.3 release #1878

Merged

mbronk pushed a commit to mbronk/IRremoteESP8266 that referenced this issue Oct 16, 2022

ARGO: Improve code & add support for decoding 32bit sensor msgs.

d3b27ed

* Add `getSensorTemp()`. * deduplicate code used. * Support decoding 32bit `ARGO` messages. For crankyoldgit#1859

mbronk pushed a commit to mbronk/IRremoteESP8266 that referenced this issue Oct 16, 2022

Add bounds checking to sendSensorTemp()

bb5b6d3

Plus some minor code & style cleanups. For crankyoldgit#1859

crankyoldgit mentioned this issue Oct 22, 2022

ARGO: Improve code & add support for decoding 32bit sensor msgs. #1906

Merged

mbronk mentioned this issue Oct 29, 2022

Add support for Argo A/C WREM-3 remote protocol #1912

Closed

mbronk mentioned this issue Nov 24, 2022

Added "commandType" to IRac, enabling support of multi-command IR protocols #1921

Merged

crankyoldgit mentioned this issue May 8, 2023

v2.8.5 release #1988

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Argo Ulisse 13 IR messages not decoding correctly #1859

Argo Ulisse 13 IR messages not decoding correctly #1859

zpin commented Aug 18, 2022

crankyoldgit commented Aug 21, 2022

zpin commented Aug 23, 2022

crankyoldgit commented Aug 23, 2022

crankyoldgit commented Aug 23, 2022

zpin commented Aug 23, 2022

mbronk commented Oct 16, 2022

mbronk commented Oct 16, 2022

mbronk commented Oct 22, 2022

crankyoldgit commented Oct 22, 2022 •

edited

Loading

crankyoldgit commented Oct 22, 2022

Argo Ulisse 13 IR messages not decoding correctly #1859

Argo Ulisse 13 IR messages not decoding correctly #1859

Comments

zpin commented Aug 18, 2022

Version/revision of the library used

Describe the bug

To Reproduce

Output of raw data from IRrecvDumpV2.ino or V3 (if applicable)

Circuit diagram and hardware used (if applicable)

I have followed the steps in the Troubleshooting Guide & read the FAQ

Has this library/code previously worked as expected for you?

crankyoldgit commented Aug 21, 2022

zpin commented Aug 23, 2022

crankyoldgit commented Aug 23, 2022

crankyoldgit commented Aug 23, 2022

zpin commented Aug 23, 2022

mbronk commented Oct 16, 2022

mbronk commented Oct 16, 2022

mbronk commented Oct 22, 2022

crankyoldgit commented Oct 22, 2022 • edited Loading

crankyoldgit commented Oct 22, 2022

crankyoldgit commented Oct 22, 2022 •

edited

Loading