Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I ended up having the same problem, and realised the root cause: in sendAc() in src/IRac.cpp, we are not passing the sleep parameter. Specifically: #1991

Closed
crankyoldgit opened this issue May 14, 2023 · 0 comments · Fixed by #1992
Closed

I ended up having the same problem, and realised the root cause: in sendAc() in src/IRac.cpp, we are not passing the sleep parameter. Specifically: #1991

crankyoldgit opened this issue May 14, 2023 · 0 comments · Fixed by #1992
Assignees
@crankyoldgit
Labels
bug enhancement

Comments

@crankyoldgit
Copy link
Owner 

          I ended up having the same problem, and realised the root cause: in sendAc() in src/IRac.cpp, we are not passing the sleep parameter. Specifically:

https://github.com/crankyoldgit/IRremoteESP8266/blob/03885a6853e67c6274a78003223e740fc01274f3/src/IRac.cpp#L3230C1-L3239

Notice how we are calling fujitsu() with no send.sleep parameter. But the function itself does accept sleep:

https://github.com/crankyoldgit/IRremoteESP8266/blob/03885a6853e67c6274a78003223e740fc01274f3/src/IRac.cpp#L1218C15-L1224

So I presume the fix is as simple as passing send.sleep to fujitsu() in sendAc().

Originally posted by @jeremyvisser in #1607 (comment)
@crankyoldgit crankyoldgit self-assigned this May 14, 2023
crankyoldgit added a commit that referenced this issue May 14, 2023
@crankyoldgit
Ensure the sleep parameter is used for the FUJITSU_AC protocol.
ac987aa 
It seems we were not passing it on in the `IRac` class.
Fixes #1991
@crankyoldgit crankyoldgit mentioned this issue May 14, 2023
Merged
crankyoldgit added a commit that referenced this issue May 15, 2023
@crankyoldgit
IRac: Ensure the sleep parameter is used for the FUJITSU_AC proto…
23177fb 
…col. (#1992)

It seems we were not passing it on in the `IRac` class.
Fixes #1991
Limb pushed a commit to Limb/IRremoteESP8266 that referenced this issue May 15, 2023
@crankyoldgit @Limb
IRac: Ensure the sleep parameter is used for the FUJITSU_AC proto…
5cc075b 
…col. (crankyoldgit#1992)

It seems we were not passing it on in the `IRac` class.
Fixes crankyoldgit#1991
crankyoldgit added a commit that referenced this issue Jul 27, 2023
@crankyoldgit
v2.8.6 release
7207c8c 
_v2.8.6 (20230727)_

**[Bug Fixes]**
- Ensure `IRCoolixAC::toCommon()` returns `kNoTempValue` when no sensor temp is detected. (#2015 #2012)
- Fix compilation dependency of LG on Samsung send protocol (#2011 #2010)
- Fix missing parameter in call to `IRac::gree()` (#2008 #2007)

**[Features]**
- IRac: Ensure the `sleep` parameter is used for the `FUJITSU_AC` protocol. (#1992 #1991)

**[Misc]**
- Allow the BlynkIRRemote.ino code to compile again. (#2016)
- do not list WHIRLPOOL_AC unconditionally as supported protocol (#2003)
- IRUtils:typeToString() — simplify (#2002)
- Fix brand Green -> Gree (#1994)
- Fix undefined `std::round` compilation error (#1989)
@crankyoldgit crankyoldgit mentioned this issue Jul 27, 2023
Merged
crankyoldgit added a commit that referenced this issue Jul 28, 2023
@crankyoldgit
v2.8.6 release (#2020)
2bfdf97 
## _v2.8.6 (20230727)_

**[Bug Fixes]**
- Ensure `IRCoolixAC::toCommon()` returns `kNoTempValue` when no sensor temp is detected. (#2015 #2012)
- Fix compilation dependency of LG on Samsung send protocol (#2011 #2010)
- Fix missing parameter in call to `IRac::gree()` (#2008 #2007)

**[Features]**
- IRac: Ensure the `sleep` parameter is used for the `FUJITSU_AC` protocol. (#1992 #1991)

**[Misc]**
- Allow the BlynkIRRemote.ino code to compile again. (#2016)
- do not list WHIRLPOOL_AC unconditionally as supported protocol (#2003)
- IRUtils:typeToString() — simplify (#2002)
- Fix brand Green -> Gree (#1994)
- Fix undefined `std::round` compilation error (#1989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure the sleep parameter is used for the FUJITSU_AC protocol. crankyoldgit/IRremoteESP8266
1 participant
@crankyoldgit